* [PATCH 1/1] imsm: fix missing error message during migration
@ 2017-01-24 13:29 Pawel Baldysiak
2017-01-27 1:59 ` jes.sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Pawel Baldysiak @ 2017-01-24 13:29 UTC (permalink / raw)
To: jes.sorensen; +Cc: linux-raid, Pawel Baldysiak
If user tries to migrate from raid0 to raid5 and there is no spare
drive to perform it - mdadm will exit with errorcode, but
no error message is printed.
Print error instead of debug message when this condition occurs,
so user is informed why requested migration is not started.
Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
---
super-intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/super-intel.c b/super-intel.c
index 433bb6d..d5e9517 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -10718,7 +10718,7 @@ static int imsm_create_metadata_update_for_migration(
free(u);
sysfs_free(spares);
update_memory_size = 0;
- dprintf("error: cannot get spare device for requested migration");
+ pr_err("cannot get spare device for requested migration\n");
return 0;
}
sysfs_free(spares);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] imsm: fix missing error message during migration
2017-01-24 13:29 [PATCH 1/1] imsm: fix missing error message during migration Pawel Baldysiak
@ 2017-01-27 1:59 ` jes.sorensen
0 siblings, 0 replies; 2+ messages in thread
From: jes.sorensen @ 2017-01-27 1:59 UTC (permalink / raw)
To: Pawel Baldysiak; +Cc: linux-raid
Pawel Baldysiak <pawel.baldysiak@intel.com> writes:
> If user tries to migrate from raid0 to raid5 and there is no spare
> drive to perform it - mdadm will exit with errorcode, but
> no error message is printed.
>
> Print error instead of debug message when this condition occurs,
> so user is informed why requested migration is not started.
>
> Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
> ---
> super-intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-27 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-24 13:29 [PATCH 1/1] imsm: fix missing error message during migration Pawel Baldysiak
2017-01-27 1:59 ` jes.sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).