From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: Robert LeBlanc <robert@leblancnet.us>, linux-raid@vger.kernel.org
Subject: Re: [mdadm PATCH] Make get_component_size() work with named array.
Date: Thu, 22 Dec 2016 12:19:27 -0500 [thread overview]
Message-ID: <wrfjeg0zkhk0.fsf@redhat.com> (raw)
In-Reply-To: <87wpespv4s.fsf@notabene.neil.brown.name> (NeilBrown's message of "Thu, 22 Dec 2016 13:14:59 +1100")
NeilBrown <neilb@suse.com> writes:
> get_component_size() still assumes that all array are
> /sys/block/md%d or /sys/block/md_d%d
> and so doesn't work with e.g. /sys/block/md_foo.
>
> This cause "mdadm --detail" to report
> Used Dev Size : unknown
> and causes problems when added spares and in other circumstances.
>
> So change it to use stat2devnm() which does the right thing with all
> types of array names.
>
> Reported-and-tested-by: Robert LeBlanc <robert@leblancnet.us>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> sysfs.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
Applied!
Thanks,
Jes
prev parent reply other threads:[~2016-12-22 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 2:14 [mdadm PATCH] Make get_component_size() work with named array NeilBrown
2016-12-22 17:19 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjeg0zkhk0.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=robert@leblancnet.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).