linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Coly Li <colyli@suse.de>
Cc: linux-raid@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
	Neil Brown <neilb@suse.com>
Subject: Re: [PATCH] Fix regression during add devices
Date: Thu, 10 Mar 2016 11:44:09 -0500	[thread overview]
Message-ID: <wrfjegbi1dwm.fsf@redhat.com> (raw)
In-Reply-To: <56E0FF30.1060807@suse.de> (Coly Li's message of "Thu, 10 Mar 2016 12:59:28 +0800")

Coly Li <colyli@suse.de> writes:
> 在 16/3/10 上午2:30, Jes Sorensen 写道:
>> Coly Li <colyli@suse.de> writes:
>>> From: Hannes Reinecke <hare@suse.de>
>>>
>>> Commit d180d2aa2a17 ("Manage: fix test for 'is array failed'.")
>>> introduced a regression which would not allow to re-add new
>>> drivers to a failed array.
>>>
>>> The patch is written by Hannes Reinecke, Neil Brown points out
>>> the buggy commit ID is d180d2aa2a17. Coly helps to submit the
>>> patch to mdadm upstream.
>>>
>>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>>> Cc: Coly Li <colyli@suse.de>
>>> Cc: Neil Brown <neilb@suse.com>
>>> ---
>>>  Manage.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> Coly,
>> 
>> Thanks for the fix - please use "Fixes: " to indicate which patch
>> introduced the bug, and the story of pushing the patch really belongs in
>> a comment below the --- line, so it doesn't go into git.
>> 
>> I modified it to look like this - please let me know if you are OK with
>> this.
>> 
>> Thanks,
>> Jes
>> 
>
> Hi Jes,
>
> It is OK to me, so I don't resend another fixed version.
> Thanks for the fix up.

Great, yes you're all set!

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2016-03-10 16:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  5:20 [PATCH] Fix regression during add devices Coly Li
2016-03-09 18:30 ` Jes Sorensen
2016-03-10  4:59   ` Coly Li
2016-03-10 16:44     ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjegbi1dwm.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=colyli@suse.de \
    --cc=hare@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).