Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] imsm: do not activate spares for uninitialized member arrays
Date: Thu, 15 Sep 2016 12:16:35 -0400	[thread overview]
Message-ID: <wrfjk2edxhng.fsf@redhat.com> (raw)
In-Reply-To: <20160915075358.16948-1-artur.paszkiewicz@intel.com> (Artur Paszkiewicz's message of "Thu, 15 Sep 2016 09:53:58 +0200")

Artur Paszkiewicz <artur.paszkiewicz@intel.com> writes:
> This fixes some issues when a member array is created with "missing"
> devices in a container that has more devices than used in the member
> array.
>
> Reported-by: Yi Zhang <yizhan@redhat.com>
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> ---
>  super-intel.c | 5 +++++
>  1 file changed, 5 insertions(+)

Applied!

Thanks,
Jes

> diff --git a/super-intel.c b/super-intel.c
> index 92817e9..032ef00 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -7789,6 +7789,11 @@ static struct mdinfo *imsm_activate_spare(struct active_array *a,
>  			IMSM_T_STATE_DEGRADED)
>  		return NULL;
>  
> +	if (get_imsm_map(dev, MAP_0)->map_state == IMSM_T_STATE_UNINITIALIZED) {
> +		dprintf("imsm: No spare activation allowed. Volume is not initialized.\n");
> +		return NULL;
> +	}
> +
>  	/*
>  	 * If there are any failed disks check state of the other volume.
>  	 * Block rebuild if the another one is failed until failed disks

      reply	other threads:[~2016-09-15 16:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  7:53 [PATCH] imsm: do not activate spares for uninitialized member arrays Artur Paszkiewicz
2016-09-15 16:16 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjk2edxhng.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox