From: jes.sorensen@gmail.com
To: Xiao Ni <xni@redhat.com>
Cc: ncroxon@redhat.com, artur.paszkiewicz@intel.com,
linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] Replace snprintf with strncpy at some places to avoid truncation
Date: Tue, 28 Mar 2017 13:55:05 -0400 [thread overview]
Message-ID: <wrfjlgrpgubq.fsf@gmail.com> (raw)
In-Reply-To: <1489804425-4949-1-git-send-email-xni@redhat.com> (Xiao Ni's message of "Sat, 18 Mar 2017 10:33:44 +0800")
Xiao Ni <xni@redhat.com> writes:
> In gcc7 there are some building errors like:
> directive output may be truncated writing up to 31 bytes into a region of size 24
> snprintf(str, MPB_SIG_LEN, %s, mpb->sig);
>
> It just need to copy one string to target. So use strncpy to replace it.
>
> For this line code: snprintf(str, MPB_SIG_LEN, %s, mpb->sig);
> Because mpb->sig has the content of version after magic, so
> it's better to use strncpy to replace snprintf too.
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
> super-intel.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Applied!
Thanks,
Jes
prev parent reply other threads:[~2017-03-28 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 2:33 [PATCH 1/2] Replace snprintf with strncpy at some places to avoid truncation Xiao Ni
2017-03-18 2:33 ` [PATCH 2/2] mdadm: Forced type conversion " Xiao Ni
2017-03-28 17:57 ` jes.sorensen
2017-03-28 17:55 ` jes.sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjlgrpgubq.fsf@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=artur.paszkiewicz@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).