From: jes.sorensen@gmail.com
To: NeilBrown <neilb@suse.com>
Cc: Linux-RAID <linux-raid@vger.kernel.org>
Subject: Re: [mdadm PATCH] Retry HOT_REMOVE_DISK a few times.
Date: Tue, 28 Mar 2017 14:26:08 -0400 [thread overview]
Message-ID: <wrfjmvc5febj.fsf@gmail.com> (raw)
In-Reply-To: <87d1d38p47.fsf@notabene.neil.brown.name> (NeilBrown's message of "Mon, 27 Mar 2017 12:50:16 +1100")
NeilBrown <neilb@suse.com> writes:
> HOT_REMOVE_DISK can fail with EBUSY if there are outstanding
> IO request that have not completed yet. It can sometimes
> be helpful to wait a little while for these to complete.
>
> We already do this in impose_level() when reshaping a device,
> but not in Manage.c in response to an explicit --remove request.
>
> So create hot_remove_disk() to central this code, and call it
> where-ever it makes sense to wait for a HOT_REMOVE_DISK to succeed.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> Grow.c | 9 +--------
> Manage.c | 4 ++--
> mdadm.h | 1 +
> util.c | 18 ++++++++++++++++++
> 4 files changed, 22 insertions(+), 10 deletions(-)
Applied!
Thanks,
Jes
prev parent reply other threads:[~2017-03-28 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 1:50 [mdadm PATCH] Retry HOT_REMOVE_DISK a few times NeilBrown
2017-03-28 18:26 ` jes.sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjmvc5febj.fsf@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).