From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Pawel Baldysiak <pawel.baldysiak@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/1] IMSM: Fix signed/unsigned comparisons
Date: Tue, 03 Jan 2017 10:34:36 -0500 [thread overview]
Message-ID: <wrfjmvf817jn.fsf@redhat.com> (raw)
In-Reply-To: <20170103142013.13132-1-pawel.baldysiak@intel.com> (Pawel Baldysiak's message of "Tue, 3 Jan 2017 15:20:13 +0100")
Pawel Baldysiak <pawel.baldysiak@intel.com> writes:
> Prior to this patch there was an error during compiling
> on 32-bit arch. This patch fixes this issue.
>
> Reported-by: Thomas Backlund <tmb@mageia.org>
> Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
> ---
> super-intel.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Hi Pawel,
I am not wildly in love with this approach, especially as it discards
the error code. I'll apply it for now, but I would like to see happen is
better explicit error handling throughout the code.
Cheers,
Jes
prev parent reply other threads:[~2017-01-03 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 14:20 [PATCH 1/1] IMSM: Fix signed/unsigned comparisons Pawel Baldysiak
2017-01-03 15:34 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjmvf817jn.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=pawel.baldysiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox