From: jes.sorensen@gmail.com
To: Song Liu <songliubraving@fb.com>
Cc: linux-raid@vger.kernel.org, shli@fb.com, neilb@suse.com,
kernel-team@fb.com, dan.j.williams@intel.com, hch@infradead.org
Subject: Re: [PATCH 2/2] mdadm: remove journal with "remove-journal"
Date: Fri, 17 Mar 2017 15:39:49 -0400 [thread overview]
Message-ID: <wrfjpohfk7zu.fsf@gmail.com> (raw)
In-Reply-To: <20170315182850.3628010-2-songliubraving@fb.com> (Song Liu's message of "Wed, 15 Mar 2017 11:28:50 -0700")
Song Liu <songliubraving@fb.com> writes:
> When journal device of an array fails, the array is forced into read-only
> mode. To make the array normal without adding another journal device, we
> need to remove journal _feature_ from the array.
>
> This patch is the mdadm part of removing journal feature for an array with
> failed or missing journal.
>
> Two flags are added to GET_ARRAY_INFO:
> 1. MD_SB_HAS_JOURNAL: meaning the array have journal feature;
> 2. MD_SB_JOURNAL_REMOVABLE: meaning the journal is faulty or missing
>
> When both flags are set, mdadm will use ioctl SET_ARRAY_INFO to clear
> MD_SB_HAS_JOURNAL, and thus remove journal feature from the array.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> Manage.c | 26 ++++++++++++++++++++++++++
> ReadMe.c | 1 +
> mdadm.c | 9 ++++++++-
> mdadm.h | 3 +++
> 4 files changed, 38 insertions(+), 1 deletion(-)
Applied!
Thanks,
Jes
next prev parent reply other threads:[~2017-03-17 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 18:28 [PATCH 1/2] mdadm/r5cache: allow adding journal to array without journal Song Liu
2017-03-15 18:28 ` [PATCH 2/2] mdadm: remove journal with "remove-journal" Song Liu
2017-03-17 19:39 ` jes.sorensen [this message]
2017-03-17 19:38 ` [PATCH 1/2] mdadm/r5cache: allow adding journal to array without journal jes.sorensen
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 15:54 [PATCH 2/2] mdadm: remove journal with "remove-journal" Larkin Lowrey
2017-08-31 17:51 ` Song Liu
2017-09-01 14:56 ` Larkin Lowrey
2017-11-16 17:35 ` Larkin Lowrey
2017-11-16 17:55 ` Song Liu
2017-11-20 16:04 ` Larkin Lowrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjpohfk7zu.fsf@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).