From mboxrd@z Thu Jan 1 00:00:00 1970 From: jes.sorensen@gmail.com Subject: Re: [PATCH 1/2] super1: ignore failfast flag for setting device role Date: Fri, 17 Mar 2017 16:20:58 -0400 Message-ID: References: <1489769222-31855-1-git-send-email-gi-oh.kim@profitbricks.com> <1489769222-31855-2-git-send-email-gi-oh.kim@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1489769222-31855-2-git-send-email-gi-oh.kim@profitbricks.com> (Gioh Kim's message of "Fri, 17 Mar 2017 17:47:01 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Gioh Kim Cc: neilb@suse.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, Jack Wang List-Id: linux-raid.ids Gioh Kim writes: > There is corner case for setting device role, > if new device has failfast flag. > The failfast flag should be ignored. > > Signed-off-by: Gioh Kim > Signed-off-by: Jack Wang > --- > super1.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/super1.c b/super1.c > index 882cd61..1da33ef 100644 > --- a/super1.c > +++ b/super1.c > @@ -1491,6 +1491,7 @@ static int add_to_super1(struct supertype *st, mdu_disk_info_t *dk, > struct devinfo *di, **dip; > bitmap_super_t *bms = (bitmap_super_t*)(((char*)sb) + MAX_SB_SIZE); > int rv, lockid; > + int dk_state; > > if (bms->version == BITMAP_MAJOR_CLUSTERED && dlm_funs_ready()) { > rv = cluster_get_dlmlock(&lockid); > @@ -1501,11 +1502,12 @@ static int add_to_super1(struct supertype *st, mdu_disk_info_t *dk, > } > } > > - if ((dk->state & 6) == 6) /* active, sync */ > + dk_state &= ~(1< + if ((dk_state & 6) == 6) /* active, sync */ > *rp = __cpu_to_le16(dk->raid_disk); This does not look right - you haven't assigned a value to dk_state, but then start masking bits out of it. Cheers, Jes