linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] Use disk sector size value to set offset for reading GPT
Date: Mon, 12 Dec 2016 14:26:32 -0500	[thread overview]
Message-ID: <wrfjwpf5rlsn.fsf@redhat.com> (raw)
In-Reply-To: <1481195595-13140-1-git-send-email-mariusz.dabrowski@intel.com> (Mariusz Dabrowski's message of "Thu, 8 Dec 2016 12:13:15 +0100")

Mariusz Dabrowski <mariusz.dabrowski@intel.com> writes:
> mdadm is using invalid byte-offset while reading GPT header to get
> partition info (size, first sector, last sector etc.). Now this offset
> is hardcoded to 512 bytes and it is not valid for disks with sector
> size different than 512 bytes because MBR and GPT headers are aligned
> to LBA, so valid offset for 4k drives is 4096 bytes.
>
> Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
> ---
>  super-gpt.c | 10 ++++++++++
>  util.c      |  7 ++++++-
>  2 files changed, 16 insertions(+), 1 deletion(-)

Applied!

Thanks,
Jes

  reply	other threads:[~2016-12-12 19:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 11:13 [PATCH] Use disk sector size value to set offset for reading GPT Mariusz Dabrowski
2016-12-12 19:26 ` Jes Sorensen [this message]
2016-12-13 16:38 ` Wols Lists
2016-12-14 11:04   ` Mariusz Dabrowski
2016-12-14 18:38     ` Wols Lists

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjwpf5rlsn.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.dabrowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).