Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] Incremental: don't try to load_container() for a subarray
Date: Tue, 09 Aug 2016 10:58:10 -0400	[thread overview]
Message-ID: <wrfjy446q9a5.fsf@redhat.com> (raw)
In-Reply-To: <20160809080551.2226-1-artur.paszkiewicz@intel.com> (Artur Paszkiewicz's message of "Tue, 9 Aug 2016 10:05:51 +0200")

Artur Paszkiewicz <artur.paszkiewicz@intel.com> writes:
> mdadm -IRs would exit with a non-zero status because of this.
>
> Reported-by: Xiao Ni <xni@redhat.com>
> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> ---
>  Incremental.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Applied!

Thanks,
Jes

> diff --git a/Incremental.c b/Incremental.c
> index ba97b00..cc01d41 100644
> --- a/Incremental.c
> +++ b/Incremental.c
> @@ -1347,8 +1347,12 @@ restart:
>  
>  		if (devnm && strcmp(devnm, me->devnm) != 0)
>  			continue;
> -		if (devnm && me->metadata[0] == '/') {
> +		if (me->metadata[0] == '/') {
>  			char *sl;
> +
> +			if (!devnm)
> +				continue;
> +
>  			/* member array, need to work on container */
>  			strncpy(container, me->metadata+1, 32);
>  			container[31] = 0;

      reply	other threads:[~2016-08-09 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09  8:05 [PATCH] Incremental: don't try to load_container() for a subarray Artur Paszkiewicz
2016-08-09 14:58 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjy446q9a5.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox