[GIT PULL REQUEST] md fixes for 4.3

[GIT PULL REQUEST] md fixes for 4.3

[Neil Brown]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]


Hi Linus,
 a few md bug fixes.
Thanks,
NeilBrown

The following changes since commit bcee19f424a0d8c26ecf2607b73c690802658b29:

  Merge branch 'for-4.3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup (2015-09-21 18:26:54 -0700)

are available in the git repository at:

  git://neil.brown.name/md tags/md/4.3-fixes

for you to fetch changes up to da6fb7a9e5bd6f04f7e15070f630bdf1ea502841:

  md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000)

----------------------------------------------------------------
Assorted fixes for md in 4.3-rc

Two tagged for -stable
One is really a cleanup to match and improve kmemcache interface.

----------------------------------------------------------------
Jes Sorensen (1):
      md/raid1: Avoid raid1 resync getting stuck

Julia Lawall (1):
      md: drop null test before destroy functions

NeilBrown (4):
      md: wait for pending superblock updates before switching to read-only
      md/raid5: don't index beyond end of array in need_this_block().
      md/raid0: apply base queue limits *before* disk_stack_limits
      md/bitmap: don't pass -1 to bitmap_storage_alloc.

Shaohua Li (2):
      raid5: update analysis state for failed stripe
      md: clear CHANGE_PENDING in readonly array

 drivers/md/bitmap.c    |  3 ++-
 drivers/md/md.c        |  5 +++++
 drivers/md/multipath.c |  3 +--
 drivers/md/raid0.c     | 12 ++++++------
 drivers/md/raid1.c     | 11 ++++-------
 drivers/md/raid10.c    |  9 +++------
 drivers/md/raid5.c     | 11 +++++++----
 7 files changed, 28 insertions(+), 26 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [GIT PULL REQUEST] md fixes for 4.3

[Alexander Lyakas]

Hello Neil,Jes,

Question about the patch
" md/raid1: Avoid raid1 resync getting stuck"

Is this patch relevant for kernel 3.18? In Linus's tree I don't see
this patch being tagged for stable[1].

Thanks,
Alex.

[1]
commit e8ff8bf09ff49733534ff3cee91bde030186055f
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date:   Wed Sep 16 10:20:05 2015 -0400

    md/raid1: Avoid raid1 resync getting stuck

    close_sync() needs to set conf->next_resync to a large, but safe value
    below MaxSector and use it to determine whether or not to set
    start_next_window in wait_barrier()

    Solution suggested by Neil Brown.

    Reported-by: Nate Dailey <nate.dailey@stratus.com>
    Tested-by: Xiao Ni <xni@redhat.com>
    Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
    Signed-off-by: NeilBrown <neilb@suse.com>




On Sun, Oct 4, 2015 at 10:39 AM, Neil Brown <neil@brown.name> wrote:
>
> Hi Linus,
>  a few md bug fixes.
> Thanks,
> NeilBrown
>
> The following changes since commit bcee19f424a0d8c26ecf2607b73c690802658b29:
>
>   Merge branch 'for-4.3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup (2015-09-21 18:26:54 -0700)
>
> are available in the git repository at:
>
>   git://neil.brown.name/md tags/md/4.3-fixes
>
> for you to fetch changes up to da6fb7a9e5bd6f04f7e15070f630bdf1ea502841:
>
>   md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000)
>
> ----------------------------------------------------------------
> Assorted fixes for md in 4.3-rc
>
> Two tagged for -stable
> One is really a cleanup to match and improve kmemcache interface.
>
> ----------------------------------------------------------------
> Jes Sorensen (1):
>       md/raid1: Avoid raid1 resync getting stuck
>
> Julia Lawall (1):
>       md: drop null test before destroy functions
>
> NeilBrown (4):
>       md: wait for pending superblock updates before switching to read-only
>       md/raid5: don't index beyond end of array in need_this_block().
>       md/raid0: apply base queue limits *before* disk_stack_limits
>       md/bitmap: don't pass -1 to bitmap_storage_alloc.
>
> Shaohua Li (2):
>       raid5: update analysis state for failed stripe
>       md: clear CHANGE_PENDING in readonly array
>
>  drivers/md/bitmap.c    |  3 ++-
>  drivers/md/md.c        |  5 +++++
>  drivers/md/multipath.c |  3 +--
>  drivers/md/raid0.c     | 12 ++++++------
>  drivers/md/raid1.c     | 11 ++++-------
>  drivers/md/raid10.c    |  9 +++------
>  drivers/md/raid5.c     | 11 +++++++----
>  7 files changed, 28 insertions(+), 26 deletions(-)

Re: [GIT PULL REQUEST] md fixes for 4.3

[Jes Sorensen]

Alexander Lyakas <alex.bolshoy@gmail.com> writes:
> Hello Neil,Jes,
>
> Question about the patch
> " md/raid1: Avoid raid1 resync getting stuck"
>
> Is this patch relevant for kernel 3.18? In Linus's tree I don't see
> this patch being tagged for stable[1].

Hi Alex,

I am not 200% sure as it's been a long time. Looking at it, I think it
falls into the category of has been around forever bugs and the patch
should be relevant for 3.18 too.

Cheers,
Jes

> [1]
> commit e8ff8bf09ff49733534ff3cee91bde030186055f
> Author: Jes Sorensen <Jes.Sorensen@redhat.com>
> Date:   Wed Sep 16 10:20:05 2015 -0400
>
>     md/raid1: Avoid raid1 resync getting stuck
>
>     close_sync() needs to set conf->next_resync to a large, but safe value
>     below MaxSector and use it to determine whether or not to set
>     start_next_window in wait_barrier()
>
>     Solution suggested by Neil Brown.
>
>     Reported-by: Nate Dailey <nate.dailey@stratus.com>
>     Tested-by: Xiao Ni <xni@redhat.com>
>     Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>     Signed-off-by: NeilBrown <neilb@suse.com>
>
>
>
>
> On Sun, Oct 4, 2015 at 10:39 AM, Neil Brown <neil@brown.name> wrote:
>>
>> Hi Linus,
>>  a few md bug fixes.
>> Thanks,
>> NeilBrown
>>
>> The following changes since commit bcee19f424a0d8c26ecf2607b73c690802658b29:
>>
>>   Merge branch 'for-4.3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup (2015-09-21 18:26:54 -0700)
>>
>> are available in the git repository at:
>>
>>   git://neil.brown.name/md tags/md/4.3-fixes
>>
>> for you to fetch changes up to da6fb7a9e5bd6f04f7e15070f630bdf1ea502841:
>>
>>   md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000)
>>
>> ----------------------------------------------------------------
>> Assorted fixes for md in 4.3-rc
>>
>> Two tagged for -stable
>> One is really a cleanup to match and improve kmemcache interface.
>>
>> ----------------------------------------------------------------
>> Jes Sorensen (1):
>>       md/raid1: Avoid raid1 resync getting stuck
>>
>> Julia Lawall (1):
>>       md: drop null test before destroy functions
>>
>> NeilBrown (4):
>>       md: wait for pending superblock updates before switching to read-only
>>       md/raid5: don't index beyond end of array in need_this_block().
>>       md/raid0: apply base queue limits *before* disk_stack_limits
>>       md/bitmap: don't pass -1 to bitmap_storage_alloc.
>>
>> Shaohua Li (2):
>>       raid5: update analysis state for failed stripe
>>       md: clear CHANGE_PENDING in readonly array
>>
>>  drivers/md/bitmap.c    |  3 ++-
>>  drivers/md/md.c        |  5 +++++
>>  drivers/md/multipath.c |  3 +--
>>  drivers/md/raid0.c     | 12 ++++++------
>>  drivers/md/raid1.c     | 11 ++++-------
>>  drivers/md/raid10.c    |  9 +++------
>>  drivers/md/raid5.c     | 11 +++++++----
>>  7 files changed, 28 insertions(+), 26 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL REQUEST] md fixes for 4.3

[Alexander Lyakas]

Hi Jes,

Thanks for your response. Since you mention that Nate from your team
bisected it to commit 79ef3a8aa1cb1523cc231c9a90a278333c21f761, which
is the raid1 barrier rework, this has not really been around forever.
For example, kernel 3.8 doesn't have this code.

Anyways, Neil mentions that two patches are tagged for stable, but not
sure which ones and which stable kernels he means.

Thanks,
Alex.



On Mon, Jun 13, 2016 at 4:31 PM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> Alexander Lyakas <alex.bolshoy@gmail.com> writes:
>> Hello Neil,Jes,
>>
>> Question about the patch
>> " md/raid1: Avoid raid1 resync getting stuck"
>>
>> Is this patch relevant for kernel 3.18? In Linus's tree I don't see
>> this patch being tagged for stable[1].
>
> Hi Alex,
>
> I am not 200% sure as it's been a long time. Looking at it, I think it
> falls into the category of has been around forever bugs and the patch
> should be relevant for 3.18 too.
>
> Cheers,
> Jes
>
>> [1]
>> commit e8ff8bf09ff49733534ff3cee91bde030186055f
>> Author: Jes Sorensen <Jes.Sorensen@redhat.com>
>> Date:   Wed Sep 16 10:20:05 2015 -0400
>>
>>     md/raid1: Avoid raid1 resync getting stuck
>>
>>     close_sync() needs to set conf->next_resync to a large, but safe value
>>     below MaxSector and use it to determine whether or not to set
>>     start_next_window in wait_barrier()
>>
>>     Solution suggested by Neil Brown.
>>
>>     Reported-by: Nate Dailey <nate.dailey@stratus.com>
>>     Tested-by: Xiao Ni <xni@redhat.com>
>>     Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>>     Signed-off-by: NeilBrown <neilb@suse.com>
>>
>>
>>
>>
>> On Sun, Oct 4, 2015 at 10:39 AM, Neil Brown <neil@brown.name> wrote:
>>>
>>> Hi Linus,
>>>  a few md bug fixes.
>>> Thanks,
>>> NeilBrown
>>>
>>> The following changes since commit bcee19f424a0d8c26ecf2607b73c690802658b29:
>>>
>>>   Merge branch 'for-4.3-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup (2015-09-21 18:26:54 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>   git://neil.brown.name/md tags/md/4.3-fixes
>>>
>>> for you to fetch changes up to da6fb7a9e5bd6f04f7e15070f630bdf1ea502841:
>>>
>>>   md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000)
>>>
>>> ----------------------------------------------------------------
>>> Assorted fixes for md in 4.3-rc
>>>
>>> Two tagged for -stable
>>> One is really a cleanup to match and improve kmemcache interface.
>>>
>>> ----------------------------------------------------------------
>>> Jes Sorensen (1):
>>>       md/raid1: Avoid raid1 resync getting stuck
>>>
>>> Julia Lawall (1):
>>>       md: drop null test before destroy functions
>>>
>>> NeilBrown (4):
>>>       md: wait for pending superblock updates before switching to read-only
>>>       md/raid5: don't index beyond end of array in need_this_block().
>>>       md/raid0: apply base queue limits *before* disk_stack_limits
>>>       md/bitmap: don't pass -1 to bitmap_storage_alloc.
>>>
>>> Shaohua Li (2):
>>>       raid5: update analysis state for failed stripe
>>>       md: clear CHANGE_PENDING in readonly array
>>>
>>>  drivers/md/bitmap.c    |  3 ++-
>>>  drivers/md/md.c        |  5 +++++
>>>  drivers/md/multipath.c |  3 +--
>>>  drivers/md/raid0.c     | 12 ++++++------
>>>  drivers/md/raid1.c     | 11 ++++-------
>>>  drivers/md/raid10.c    |  9 +++------
>>>  drivers/md/raid5.c     | 11 +++++++----
>>>  7 files changed, 28 insertions(+), 26 deletions(-)
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html