From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: Anuj gupta <anuj1072538@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, M Nikhil <nikh1092@linux.ibm.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, nvdimm@lists.linux.dev,
linux-scsi@vger.kernel.org, hare@suse.de,
steffen Maier <maier@linux.ibm.com>,
Benjamin Block <bblock@linux.ibm.com>,
Nihar Panda <niharp@linux.ibm.com>
Subject: Re: Change in reported values of some block integrity sysfs attributes
Date: Mon, 24 Feb 2025 20:07:18 -0500 [thread overview]
Message-ID: <yq1frk2debi.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250221120729.GA5233@green245> (Anuj Gupta's message of "Fri, 21 Feb 2025 17:37:29 +0530")
Anuj,
> diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c
> index ae6ce6f5d622..be2cd06f500b 100644
> --- a/drivers/scsi/sd_dif.c
> +++ b/drivers/scsi/sd_dif.c
> @@ -40,8 +40,10 @@ void sd_dif_config_host(struct scsi_disk *sdkp, struct queue_limits *lim)
> dif = 0; dix = 1;
> }
>
> - if (!dix)
> + if (!dix) {
> + bi->flags |= BLK_INTEGRITY_NOGENERATE | BLK_INTEGRITY_NOVERIFY;
> return;
> + }
>
> /* Enable DMA of protection information */
> if (scsi_host_get_guard(sdkp->device->host) & SHOST_DIX_GUARD_IP)
>
This looks good to me. Originally we didn't register an integrity
profile at all unless the device was capable.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2025-02-25 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 7:16 Change in reported values of some block integrity sysfs attributes M Nikhil
2024-12-13 14:33 ` Christoph Hellwig
2024-12-17 12:46 ` M Nikhil
2024-12-13 22:30 ` Martin K. Petersen
2024-12-17 12:39 ` M Nikhil
2025-02-21 6:01 ` M Nikhil
2025-02-21 10:37 ` Anuj gupta
2025-02-21 10:35 ` Anuj Gupta
2025-02-21 12:07 ` Anuj Gupta
2025-02-25 1:07 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1frk2debi.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=bblock@linux.ibm.com \
--cc=dm-devel@lists.linux.dev \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=niharp@linux.ibm.com \
--cc=nikh1092@linux.ibm.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).