From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>, Song Liu <song@kernel.org>,
Yu Kuai <yukuai3@huawei.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-raid@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 2/3] block: move the block layer auto-integrity code into a new file
Date: Tue, 18 Feb 2025 20:35:38 -0500 [thread overview]
Message-ID: <yq1ldu2ogxw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250218182207.3982214-3-hch@lst.de> (Christoph Hellwig's message of "Tue, 18 Feb 2025 19:21:57 +0100")
Christoph,
> The code that automatically creates a integrity payload and generates
> / verifies the checksums for bios that don't have submitter-provided
> integrity payload currently sits right in the middle of the block
> integrity metadata infrastruture. Split it into a separate file to
> make the different layers clear.
Looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2025-02-19 1:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 18:21 split out the auto-PI code and data structures Christoph Hellwig
2025-02-18 18:21 ` [PATCH 1/3] block: mark bounce buffering as incompatible with integrity Christoph Hellwig
2025-02-18 18:30 ` Johannes Thumshirn
2025-02-19 16:35 ` Hannes Reinecke
2025-02-21 6:04 ` Anuj gupta
2025-02-18 18:21 ` [PATCH 2/3] block: move the block layer auto-integrity code into a new file Christoph Hellwig
2025-02-18 18:28 ` Johannes Thumshirn
2025-02-19 1:35 ` Martin K. Petersen [this message]
2025-02-19 11:33 ` Kanchan Joshi
2025-02-19 16:37 ` Hannes Reinecke
2025-02-21 6:04 ` Anuj gupta
2025-02-18 18:21 ` [PATCH 3/3] block: split struct bio_integrity_data Christoph Hellwig
2025-02-19 11:34 ` Kanchan Joshi
2025-02-19 16:40 ` Hannes Reinecke
2025-02-21 6:07 ` Anuj gupta
-- strict thread matches above, loose matches on Subject: below --
2025-02-25 15:44 split out the auto-PI code and data structures v2 Christoph Hellwig
2025-02-25 15:44 ` [PATCH 2/3] block: move the block layer auto-integrity code into a new file Christoph Hellwig
2025-01-31 12:24 RFC: split out the auto-PI code and data structures Christoph Hellwig
2025-01-31 12:24 ` [PATCH 2/3] block: move the block layer auto-integrity code into a new file Christoph Hellwig
2025-02-03 19:41 ` Martin K. Petersen
2025-02-04 5:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ldu2ogxw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).