linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Neil Brown <neilb@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Mike Snitzer <snitzer@gmail.com>,
	linux-raid@vger.kernel.org, snitzer@redhat.com,
	jens.axboe@oracle.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] md: Use new topology calls to indicate alignment and I/O  sizes
Date: Thu, 25 Jun 2009 12:24:53 -0400	[thread overview]
Message-ID: <yq1ocscqo16.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <19011.5723.905426.951624@notabene.brown> (Neil Brown's message of "Thu, 25 Jun 2009 16:16:59 +1000")

>>>>> "Neil" == Neil Brown <neilb@suse.de> writes:

Neil> Here you're thinking seems be very specific.  This value comes
Neil> from that spec.  That value is used for this particular
Neil> application.  Yet....

[...]

Neil> ...here you are being deliberately vague.  But with the exact same
Neil> values.  I find this confusing.

That's because I distinguish between hardware-imposed limits and
software-imposed ditto.  You don't think there's a difference.  I do.
We don't have any control whatsoever over the hardware limits.  We do
have full control over the software ones.

hw_sector_size is dead and has been replaced with logical_block_size and
physical_block_size to accommodate new hardware devices.  That's all
there is to that.  Full stop.

The presence of lbs and pbs is completely orthogonal to I/O hints
provided by hardware as well as software RAID devices.  The only thing
the two concepts have in common is that we need to make sure that any
hints applied by stacking drivers are compatible with the underlying
storage limitations.

You could argue that an MD device shouldn't have logical and physical
block size exposed at all.  To some extent I agree.  However, some
applications actually *do* require intimate knowledge about the
hardware.  Consequently I am in favor of having the knobs exposed.
Besides, the values are also being used extensively by the stacking
logic.

The desire to have knowledge about the hardware is not exclusively a
storage thing.  Page size, for instance.  Most applications don't care
about the page size.  That doesn't mean we remove getpagesize() or pack
it into something that applies equally well to all applications
(memory_allocation_granularity() !?).  It is a knob that available for
the few applications that need it.  The same goes for
physical_block_size.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2009-06-25 16:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-23  4:54 [PATCH] md: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-06-23 21:44 ` Mike Snitzer
2009-06-24  4:05   ` Neil Brown
2009-06-24  5:03     ` Martin K. Petersen
2009-06-24  6:22       ` Neil Brown
2009-06-24 15:27         ` Mike Snitzer
2009-06-24 16:27           ` Mike Snitzer
2009-06-24 23:28           ` Neil Brown
2009-06-25  0:05             ` Martin K. Petersen
2009-06-24 17:07         ` [PATCH] " Martin K. Petersen
2009-06-25  2:35           ` Neil Brown
2009-06-25  4:37             ` Martin K. Petersen
2009-06-25  6:16               ` Neil Brown
2009-06-25 16:24                 ` Martin K. Petersen [this message]
2009-06-30 20:24     ` Mike Snitzer
2009-06-30 23:58       ` Neil Brown
  -- strict thread matches above, loose matches on Subject: below --
2009-06-09  4:31 [PATCH] " Martin K. Petersen
2009-06-09  5:02 ` NeilBrown
2009-06-10  6:47   ` Martin K. Petersen
2009-06-11 10:25     ` Neil Brown
2009-06-12  4:43       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ocscqo16.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=snitzer@gmail.com \
    --cc=snitzer@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).