From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 09/18] scsi_dh_emc: switch to scsi_execute_req_flags() Date: Wed, 25 Jan 2017 22:19:33 -0500 Message-ID: References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485365126-23210-10-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1485365126-23210-10-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Wed, 25 Jan 2017 18:25:17 +0100") Sender: linux-scsi-owner@vger.kernel.org To: Christoph Hellwig Cc: Jens Axboe , Mike Snitzer , Junichi Nomura , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, Hannes Reinecke , Hannes Reinecke List-Id: linux-raid.ids >>>>> "Christoph" == Christoph Hellwig writes: Christoph> From: Hannes Reinecke Switch to Christoph> scsi_execute_req_flags() and scsi_get_vpd_page() instead of Christoph> open-coding it. Using scsi_execute_req_flags() will set Christoph> REQ_QUIET and REQ_PREEMPT, but this is okay as we're Christoph> evaluating the errors anyway and should be able to send the Christoph> command even if the device is quiesced. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering