Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags

Jason Gunthorpe
2015-06-30T16:42:47Z

> NFSRDMA currently checks the transport type to decide how to set the
> access flags for memory registration. With the new services
> exported in this series, we can change/simplify NFSRDMA to not have
> to know the transport type.

It would be excellent if this series actually went through and got rid
of all the now deprecated users. This would confirm we have the right
API here and prune off the old stuff. This is fairly trivial to do, I
think?

The goal is to make things simpler, maintaining two kernel APIs is not
simpler :)

Regarding Sagi's comments .. We don't have to do everything at once,
a series that focuses only on the access flags seems sane to
me.

Sagi's idea makes a lot of sense, but maybe it should be explored
along the direction Christoph has been talking about?

I suggested the wrapper because it makes it very easy to force the old
API out (just remove the old function call), but maybe we could move
the old style access flags into a private header or something ?

Jason