* [PATCH] cxgb4: Remove duplicate tcp-options clearing
@ 2014-06-24 11:34 Christoph Paasch
[not found] ` <1403609642-27757-1-git-send-email-christoph.paasch-MkR3pAKDJcQFHpyHPIa6Kw@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Paasch @ 2014-06-24 11:34 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Steve Wise, Roland Dreier, Sean Hefty, Hal Rosenstock
tmp_opt is memset to 0. Thus, no need for another call to
tcp_clear_options which simply sets some fields explicitly to 0 again.
Cc: Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Christoph Paasch <christoph.paasch-MkR3pAKDJcQFHpyHPIa6Kw@public.gmane.org>
---
drivers/infiniband/hw/cxgb4/cm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 96d7131ab974..2106a6dc62b3 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3326,7 +3326,6 @@ static void build_cpl_pass_accept_req(struct sk_buff *skb, int stid , u8 tos)
* to generate cpl_pass_accept_req.
*/
memset(&tmp_opt, 0, sizeof(tmp_opt));
- tcp_clear_options(&tmp_opt);
tcp_parse_options(skb, &tmp_opt, 0, NULL);
req = (struct cpl_pass_accept_req *)__skb_push(skb, sizeof(*req));
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] cxgb4: Remove duplicate tcp-options clearing
[not found] ` <1403609642-27757-1-git-send-email-christoph.paasch-MkR3pAKDJcQFHpyHPIa6Kw@public.gmane.org>
@ 2014-06-24 13:49 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2014-06-24 13:49 UTC (permalink / raw)
To: 'Christoph Paasch', linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: 'Steve Wise', 'Roland Dreier',
'Sean Hefty', 'Hal Rosenstock'
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 11:34 [PATCH] cxgb4: Remove duplicate tcp-options clearing Christoph Paasch
[not found] ` <1403609642-27757-1-git-send-email-christoph.paasch-MkR3pAKDJcQFHpyHPIa6Kw@public.gmane.org>
2014-06-24 13:49 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox