From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH V3 3/4] RDMA/iser: limit sg tablesize to device fastreg max depth Date: Wed, 1 Jul 2015 13:11:56 -0500 Message-ID: <005201d0b429$6a26c950$3e745bf0$@opengridcomputing.com> References: <20150701162936.6501.45512.stgit@build.ogc.int> <20150701163052.6501.27775.stgit@build.ogc.int> <55941E6F.5080208@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55941E6F.5080208-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Sagi Grimberg' , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org > -----Original Message----- > From: Sagi Grimberg [mailto:sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org] > Sent: Wednesday, July 01, 2015 12:08 PM > To: Steve Wise; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org > Cc: roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org > Subject: Re: [PATCH V3 3/4] RDMA/iser: limit sg tablesize to device fastreg max depth > > On 7/1/2015 7:30 PM, Steve Wise wrote: > > Signed-off-by: Steve Wise > > --- > > drivers/infiniband/ulp/iser/iscsi_iser.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c > > index 6a594aa..ec692f7 100644 > > --- a/drivers/infiniband/ulp/iser/iscsi_iser.c > > +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c > > @@ -640,6 +640,13 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep, > > SHOST_DIX_GUARD_CRC); > > } > > > > + /* > > + * Limit the sg_tablesize based on the device max fastreg page > > + * list length. > > + */ > > + shost->sg_tablesize = min_t(u32, shost->sg_tablesize, > > + ib_conn->device->dev_attr.max_fast_reg_page_list_len); > > + > > if (iscsi_host_add(shost, > > ib_conn->device->ib_device->dma_device)) { > > mutex_unlock(&iser_conn->state_mutex); > > > > You forgot to add my Reviewed-by on this. > > So again (for patchworks), > > Reviewed-by: Sagi Grimberg My bad...Sorry Sagi! -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html