From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Date: Mon, 28 Sep 2015 09:50:58 -0500 Message-ID: <005401d0f9fd$16399920$42accb60$@opengridcomputing.com> References: <20150921172423.9761.92399.stgit@build2.ogc.int> <56094F16.3040608@opengridcomputing.com> <56095286.6030201@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <56095286.6030201-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Content-Language: en-us Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Anna Schumaker' , trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > -----Original Message----- > From: Anna Schumaker [mailto:Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org] > Sent: Monday, September 28, 2015 9:45 AM > To: Steve Wise; trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org; bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org > Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers > > Hi Steve, > > On 09/28/2015 10:30 AM, Steve Wise wrote: > > On 9/21/2015 12:24 PM, Steve Wise wrote: > >> Otherwise a FRMR completion can cause a touch-after-free crash. > >> > >> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling > >> rpcrdma_ep_destroy(). > >> > >> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the > >> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs. > >> > >> Signed-off-by: Steve Wise > >> Tested-by: Chuck Lever > >> --- > > > > Hey Trond, I'm hoping this can make 4.3-rc (and stable if you agree). > > This patch looks fine to me. I'll pass it on to Trond! > > I'll save patch 3/3 for the Linux 4.4 merge. > > Thanks, > Anna > Thanks. Going forward I'll make sure you are CC'd for client patches too! I wasn't sure if you are formally taking all xprtrdma patches and sending them to Trond... Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html