From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH V4 for-next 02/10] IB/core: Introduce Work Queue object and its verbs Date: Tue, 24 May 2016 09:25:41 -0500 Message-ID: <007001d1b5c8$26c9c8a0$745d59e0$@opengridcomputing.com> References: <1464006056-19653-1-git-send-email-yishaih@mellanox.com> <1464006056-19653-3-git-send-email-yishaih@mellanox.com> <5d0982d2-3b07-11a3-a74c-a52b8e9fb392@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Yishai Hadas' Cc: 'Yishai Hadas' , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, alexv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > Hey Yishai, > > > > What happens to posted RQ WRs when transitioning from RDY->RESET, > > RDY->ERR, and ERR->RESET? > > Shouldn't the state machine be defined more? > > When the external RQ (i.e. WQ from type RQ) is moved to error/reset > state it will behave similarly to the receive queue part of a QP when it > enters error/reset state. > > Specifically, > When moving to RESET: > RQ attributes are reset to the same values after the RQ was created. > Outstanding Work Requests are removed from the queues without notifying > the Consumer. > > When Moving to ERR: > RQ processing is stopped. Work Requests pending or in process are > completed in error. > Thanks for the explanation. These semantics should be documented somewhere. This series appears to me to be reasonable. Series Reviewed-by: Steve Wise Thanks, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html