public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: "'Hefty,
	Sean'" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	'Jason Gunthorpe'
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: 'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	'Liran Liss' <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	'linux-rdma' <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [RFC] rdma/uverbs: Sketch for an ioctl framework
Date: Wed, 25 May 2016 17:47:29 -0500	[thread overview]
Message-ID: <007201d1b6d7$6af5c2d0$40e14870$@opengridcomputing.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373AB050A07-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>

> 
> > > I want the core ioctl framework to do this:
> > >
> > > 1. Map user objects to/from the kernel to validate pointers.
> > > 2. Provide reference counting on such objects, in order to protect against
the
> user attempting to
> > destroy objects that are in use.
> > > 3. Provide protection that the state of an object is not driven in two
different
> directions.
> > > 4. Safely process the removal of the underlying driver or device.
> > > 5. Support driver specific operations to the kernel.
> > > 6. Report events from multiple sources to a single file descriptor.
> > > 7. Minimize the kernel footprint for allocated kernel objects.
> > > 8. Minimize the code path needed to process any ioctl, without greatly
affecting
> maintainability.
> > > 9. Copy ioctl input/output data to/from the kernel.
> >
> > I agree with all of this as a suitable goal for the common
> > dispatch/marshal framework.
> >
> > I like the idea of the generic uobject stuff in your patches.
> >
> > #6 seems 'not like the others' - seems like a reasonable concrete
> > thing to consider as we build the objects on the
> > framework. [understanding that compat operation is still required]
> 
> I agree.  Handling event reporting in general is slightly different from the
other
> objections.  But it ties in with object close processing, so I think the
framework
> needs something here.
> 
> #6 is based on examining the application APIs and driving requirements down.
I.e.
> poll a single fd to get all events: CQ notifications, async events, CM
disconnect
> events, etc.  And while I'm thinking about it, expand events to support user
> specified.  This would allow many apps to rid themselves of socketpairs which
> currently fill that role.
>

Applications I have written that block typically put the CQ, async, rdmacm fds
all into an poll/epoll group and block that way.  But a common mechanism for
events might end up cleaner and simpler...



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-05-25 22:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  6:25 [RFC] rdma/uverbs: Sketch for an ioctl framework Hefty, Sean
     [not found] ` <1828884A29C6694DAF28B7E6B8A82373AB04FB7F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-24 16:02   ` Liran Liss
     [not found]     ` <HE1PR05MB141819B27F9AAA360DCB420FB14F0-eBadYZ65MZ87O8BmmlM1zNqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-24 17:57       ` Doug Ledford
     [not found]         ` <11b6d9c1-0b20-f929-c896-ca084fe18192-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-24 21:41           ` Jason Gunthorpe
     [not found]             ` <20160524214137.GA6760-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-24 22:38               ` Hefty, Sean
     [not found]                 ` <1828884A29C6694DAF28B7E6B8A82373AB0502ED-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-24 23:13                   ` Jason Gunthorpe
     [not found]                     ` <20160524231359.GA10664-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-25 14:59                       ` Hefty, Sean
     [not found]                         ` <1828884A29C6694DAF28B7E6B8A82373AB050592-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-25 17:06                           ` Jason Gunthorpe
2016-05-25 14:44               ` Liran Liss
2016-05-25 18:06               ` Doug Ledford
     [not found]                 ` <5745E9AE.6020700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-25 19:00                   ` Jason Gunthorpe
     [not found]                     ` <20160525190039.GA5525-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-25 19:31                       ` Doug Ledford
2016-05-25 19:59                       ` Hefty, Sean
     [not found]                         ` <1828884A29C6694DAF28B7E6B8A82373AB050907-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-25 20:51                           ` Jason Gunthorpe
     [not found]                             ` <20160525205156.GB5525-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-25 21:46                               ` Hefty, Sean
     [not found]                                 ` <1828884A29C6694DAF28B7E6B8A82373AB050A07-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-25 22:13                                   ` Jason Gunthorpe
     [not found]                                     ` <20160525221340.GB6207-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-25 22:24                                       ` Hefty, Sean
2016-05-25 22:47                                   ` Steve Wise [this message]
2016-05-26 18:07                               ` Liran Liss
     [not found]                                 ` <HE1PR05MB1418B4396F696F763D67A893B1410-eBadYZ65MZ87O8BmmlM1zNqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-26 18:43                                   ` Jason Gunthorpe
     [not found]                                     ` <20160526184348.GA22174-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-27  0:22                                       ` Hefty, Sean
     [not found]                                         ` <1828884A29C6694DAF28B7E6B8A82373AB05BBED-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-05-27 16:50                                           ` Jason Gunthorpe
     [not found]                                             ` <20160527165023.GA2449-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-27 17:24                                               ` Hefty, Sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007201d1b6d7$6af5c2d0$40e14870$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox