* [PATCH v1 1/1] [librdmacm] examples/rping.c: fix unwanted abort during qp creation
@ 2016-05-09 7:44 Potnuri Bharat Teja
[not found] ` <1462779876-9480-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Potnuri Bharat Teja @ 2016-05-09 7:44 UTC (permalink / raw)
To: sean.hefty-ral2JQCrhuEAvxtiuMwx3w
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ, Potnuri Bharat Teja
Memset rping control block structure to 0 to avoid accessing garbage
values in the upcoming checks in librdmacm causing unwanted abort during
creation of qp.
Fixes: b873915aee7b ("librdmacm/rping: Persistent rping server")
Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
examples/rping.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/rping.c b/examples/rping.c
index a5aa8c5f38d6..a0d10779a8b1 100644
--- a/examples/rping.c
+++ b/examples/rping.c
@@ -759,6 +759,7 @@ static struct rping_cb *clone_cb(struct rping_cb *listening_cb)
struct rping_cb *cb = malloc(sizeof *cb);
if (!cb)
return NULL;
+ memset(cb, 0, sizeof *cb);
*cb = *listening_cb;
cb->child_cm_id->context = cb;
return cb;
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] [librdmacm] examples/rping.c: fix unwanted abort during qp creation
[not found] ` <1462779876-9480-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
@ 2016-05-17 16:18 ` Steve Wise
2016-05-17 16:29 ` Hefty, Sean
2016-05-19 22:19 ` Hefty, Sean
1 sibling, 1 reply; 4+ messages in thread
From: Steve Wise @ 2016-05-17 16:18 UTC (permalink / raw)
To: 'Potnuri Bharat Teja', sean.hefty-ral2JQCrhuEAvxtiuMwx3w
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ
>
> Memset rping control block structure to 0 to avoid accessing garbage
> values in the upcoming checks in librdmacm causing unwanted abort during
> creation of qp.
>
> Fixes: b873915aee7b ("librdmacm/rping: Persistent rping server")
>
> Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Looks good.
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Sean, does this look good to merge?
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] [librdmacm] examples/rping.c: fix unwanted abort during qp creation
2016-05-17 16:18 ` Steve Wise
@ 2016-05-17 16:29 ` Hefty, Sean
0 siblings, 0 replies; 4+ messages in thread
From: Hefty, Sean @ 2016-05-17 16:29 UTC (permalink / raw)
To: Steve Wise, 'Potnuri Bharat Teja'
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Sean, does this look good to merge?
Yes - I have it marked in my inbox, just haven't take time to merge it. Sorry, I should have responded sooner with at least an update.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] [librdmacm] examples/rping.c: fix unwanted abort during qp creation
[not found] ` <1462779876-9480-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2016-05-17 16:18 ` Steve Wise
@ 2016-05-19 22:19 ` Hefty, Sean
1 sibling, 0 replies; 4+ messages in thread
From: Hefty, Sean @ 2016-05-19 22:19 UTC (permalink / raw)
To: Potnuri Bharat Teja
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Thanks - applied
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-19 22:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-09 7:44 [PATCH v1 1/1] [librdmacm] examples/rping.c: fix unwanted abort during qp creation Potnuri Bharat Teja
[not found] ` <1462779876-9480-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2016-05-17 16:18 ` Steve Wise
2016-05-17 16:29 ` Hefty, Sean
2016-05-19 22:19 ` Hefty, Sean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox