From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Sagi Grimberg' <sagi-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org>,
'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Armen Baloyan'
<armenx.baloyan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Jay Freyensee'
<james.p.freyensee-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Ming Lin' <ming.l-Vzezgt5dB6uUEJcrhfAQsw@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver
Date: Tue, 14 Jun 2016 11:10:34 -0500 [thread overview]
Message-ID: <00f501d1c657$483a74e0$d8af5ea0$@opengridcomputing.com> (raw)
In-Reply-To: <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com>
>
> The above nvmet cm event handler, nvmet_rdma_cm_handler(), calls
> nvmet_rdma_queue_connect() for CONNECT_REQUEST events, which calls
> nvmet_rdma_alloc_queue (), which, if it encounters a failure (like creating
> the qp), calls nvmet_rdma_cm_reject () which calls rdma_reject(). The
> non-zero error, however, gets returned back here and this function returns
> the error to the RDMA_CM which will also reject the connection as well as
> destroy the cm_id. So there are two rejects happening, I think. Either
> nvmet should reject and destroy the cm_id, or it should do neither and
> return non-zero to the RDMA_CM to reject/destroy.
>
> Steve.
>
Hey Sean,
Am I correct here? IE: Is it ok for the rdma application to rdma_reject() and
rmda_destroy_id() the CONNECT_REQUEST cm_id _inside_ its event handler as long
as it returns 0?
Thanks,
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-14 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465248215-18186-1-git-send-email-hch@lst.de>
2016-06-07 11:57 ` NVMe over Fabrics RDMA transport drivers Sagi Grimberg
[not found] ` <5756B695.5020305-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-06-07 12:01 ` Christoph Hellwig
2016-06-07 14:55 ` Woodruff, Robert J
2016-06-07 20:14 ` Steve Wise
2016-06-07 20:27 ` Christoph Hellwig
[not found] ` <1465248215-18186-4-git-send-email-hch@lst.de>
[not found] ` <1465248215-18186-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-06-07 11:59 ` [PATCH 3/5] nvme-rdma.h: Add includes for nvme rdma_cm negotiation Sagi Grimberg
[not found] ` <1465248215-18186-5-git-send-email-hch@lst.de>
2016-06-07 12:00 ` [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver Sagi Grimberg
[not found] ` <5756B75C.9000409-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org>
2016-06-09 21:42 ` Steve Wise
2016-06-09 21:54 ` Ming Lin
2016-06-14 14:32 ` Christoph Hellwig
2016-06-09 23:03 ` Steve Wise
2016-06-14 14:31 ` Christoph Hellwig
2016-06-14 15:14 ` Steve Wise
[not found] ` <00ea01d1c64f$64db8880$2e929980$@opengridcomputing.com>
2016-06-14 15:23 ` Steve Wise
2016-06-14 16:10 ` Steve Wise [this message]
2016-06-14 16:22 ` Steve Wise
2016-06-15 18:32 ` Sagi Grimberg
2016-06-14 16:47 ` Hefty, Sean
[not found] ` <1465248215-18186-6-git-send-email-hch@lst.de>
[not found] ` <1465248215-18186-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-06-07 12:00 ` [PATCH 5/5] nvme-rdma: add a NVMe over Fabrics RDMA host driver Sagi Grimberg
2016-07-06 12:55 NVMe over Fabrics RDMA transport drivers V2 Christoph Hellwig
[not found] ` <1467809752-31320-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-07-06 12:55 ` [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver Christoph Hellwig
[not found] ` <1467809752-31320-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-07-08 13:51 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00f501d1c657$483a74e0$d8af5ea0$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=armenx.baloyan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=james.p.freyensee-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ming.l-Vzezgt5dB6uUEJcrhfAQsw@public.gmane.org \
--cc=sagi-ImC7XgPzLAfvYQKSrp0J2Q@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).