[PATCH rdma-core] iwpmd: fix double mutex unlock

[PATCH rdma-core] iwpmd: fix double mutex unlock

[Potnuri Bharat Teja]

pthread_mutex_unlock() is used twice and this patch fixes it.

Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
 iwpmd/iwarp_pm_helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
index bebc151f329b..b8c230189d50 100644
--- a/iwpmd/iwarp_pm_helper.c
+++ b/iwpmd/iwarp_pm_helper.c
@@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg *send_msg)
 
 	pthread_mutex_lock(&pending_msg_mutex);
 	list_add(&pending_messages, &pending_msg->entry);
- 	pthread_mutex_unlock(&pending_msg_mutex);
 	pthread_mutex_unlock(&pending_msg_mutex);
 	/* signal the thread that a new message has been posted */
 	pthread_cond_signal(&cond_pending_msg);
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Steve Wise]

> 
> pthread_mutex_unlock() is used twice and this patch fixes it.
> 
> Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> ---
>  iwpmd/iwarp_pm_helper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> index bebc151f329b..b8c230189d50 100644
> --- a/iwpmd/iwarp_pm_helper.c
> +++ b/iwpmd/iwarp_pm_helper.c
> @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> *send_msg)
> 
>  	pthread_mutex_lock(&pending_msg_mutex);
>  	list_add(&pending_messages, &pending_msg->entry);
> - 	pthread_mutex_unlock(&pending_msg_mutex);
>  	pthread_mutex_unlock(&pending_msg_mutex);
>  	/* signal the thread that a new message has been posted */
>  	pthread_cond_signal(&cond_pending_msg);

Good catch.

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Steve Wise]

> >
> > pthread_mutex_unlock() is used twice and this patch fixes it.
> >
> > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > ---
> >  iwpmd/iwarp_pm_helper.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > index bebc151f329b..b8c230189d50 100644
> > --- a/iwpmd/iwarp_pm_helper.c
> > +++ b/iwpmd/iwarp_pm_helper.c
> > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > *send_msg)
> >
> >  	pthread_mutex_lock(&pending_msg_mutex);
> >  	list_add(&pending_messages, &pending_msg->entry);
> > - 	pthread_mutex_unlock(&pending_msg_mutex);
> >  	pthread_mutex_unlock(&pending_msg_mutex);
> >  	/* signal the thread that a new message has been posted */
> >  	pthread_cond_signal(&cond_pending_msg);
> 
> Good catch.
> 
> Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

And this definitely needs to flow to stable.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

On Wed, 2018-01-31 at 10:04 -0600, Steve Wise wrote:
> > > 
> > > pthread_mutex_unlock() is used twice and this patch fixes it.
> > > 
> > > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > ---
> > >  iwpmd/iwarp_pm_helper.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > > index bebc151f329b..b8c230189d50 100644
> > > --- a/iwpmd/iwarp_pm_helper.c
> > > +++ b/iwpmd/iwarp_pm_helper.c
> > > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > > *send_msg)
> > > 
> > >  	pthread_mutex_lock(&pending_msg_mutex);
> > >  	list_add(&pending_messages, &pending_msg->entry);
> > > - 	pthread_mutex_unlock(&pending_msg_mutex);
> > >  	pthread_mutex_unlock(&pending_msg_mutex);
> > >  	/* signal the thread that a new message has been posted */
> > >  	pthread_cond_signal(&cond_pending_msg);
> > 
> > Good catch.
> > 
> > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> 
> And this definitely needs to flow to stable.
> 

Applied to master branch, thanks.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Steve Wise]

> Subject: Re: [PATCH rdma-core] iwpmd: fix double mutex unlock
> 
> On Wed, 2018-01-31 at 10:04 -0600, Steve Wise wrote:
> > > >
> > > > pthread_mutex_unlock() is used twice and this patch fixes it.
> > > >
> > > > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > > > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > ---
> > > >  iwpmd/iwarp_pm_helper.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > > > index bebc151f329b..b8c230189d50 100644
> > > > --- a/iwpmd/iwarp_pm_helper.c
> > > > +++ b/iwpmd/iwarp_pm_helper.c
> > > > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > > > *send_msg)
> > > >
> > > >  	pthread_mutex_lock(&pending_msg_mutex);
> > > >  	list_add(&pending_messages, &pending_msg->entry);
> > > > - 	pthread_mutex_unlock(&pending_msg_mutex);
> > > >  	pthread_mutex_unlock(&pending_msg_mutex);
> > > >  	/* signal the thread that a new message has been posted */
> > > >  	pthread_cond_signal(&cond_pending_msg);
> > >
> > > Good catch.
> > >
> > > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> >
> > And this definitely needs to flow to stable.
> >
> 
> Applied to master branch, thanks.
> 

Thanks Doug.  Do I need to do some process magic to get it into stable and spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?  

Steve.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

On Wed, 2018-01-31 at 15:12 -0600, Steve Wise wrote:
> > Applied to master branch, thanks.
> > 
> 
> Thanks Doug.  Do I need to do some process magic to get it into stable and spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?  

I added a comment to the commit on github and tagged you and Nicolas. 
He should pull it back for you.
 
-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [PATCH rdma-core] iwpmd: fix double mutex unlock

[Steve Wise]

> 
> On Wed, 2018-01-31 at 15:12 -0600, Steve Wise wrote:
> > > Applied to master branch, thanks.
> > >
> >
> > Thanks Doug.  Do I need to do some process magic to get it into stable and
> spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?
> 
> I added a comment to the commit on github and tagged you and Nicolas.
> He should pull it back for you.
> 

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html