RE: [PATCH v2 0/3] new ib_drain_qp() API

["Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

> > The problem is SRP creates its SQ CQ with IB_POLL_DIRECT context, so the CQ is never armed for interrupts, and SRP polls the CQ
> > directly.  So the drain logic won't work.
> >
> > I propose ib_drain_qp() takes a new parameter that tells it which queues to drain.  Then the SRP code will only drain the RQ
(which
> > is what it is doing prior to this series).
> 
> Hello Steve,
> 
> How about creating three functions - one that drains the receive queue,
> one that drains the send queue and a third function that drains both ?
> The latter function then can call the two former functions. And since
> only one of these three functions will have a user in your patch series
> (the function that drains the RQ), how about only introducing only that
> function now and to wait with introducing the two other functions until
> these have a user ?

That sounds reasonable.  Simpler too perhaps.  We'll see if anyone else has an opinion.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html