merge struct ib_device_attr into struct ib_device

merge struct ib_device_attr into struct ib_device

[Christoph Hellwig]

This patch gets rid of struct ib_device_attr and cleans up drivers nicely.

It goes on top of my send_wr cleanups and the memory registration udpates
from Sagi.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: merge struct ib_device_attr into struct ib_device

[Yann Droneaud]

Le lundi 21 septembre 2015 à 13:59 -0700, Christoph Hellwig a écrit :
> This patch gets rid of struct ib_device_attr and cleans up drivers
> nicely.
> 
> It goes on top of my send_wr cleanups and the memory registration
> udpates
> from Sagi.
> 

Is the patch missing ?

Regards.

-- 
Yann Droneaud
OPTEYA

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: merge struct ib_device_attr into struct ib_device

[Christoph Hellwig]

Hi Yann,

looks like the patch was too large and majordomo ate it

Here is a link:

http://git.infradead.org/users/hch/rdma.git/commitdiff/0e46553467cd01b63ab9c985f87c18c5328880bb
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: merge struct ib_device_attr into struct ib_device

[Steve Wise]

> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Christoph Hellwig
> Sent: Tuesday, September 22, 2015 3:32 PM
> To: Yann Droneaud
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: merge struct ib_device_attr into struct ib_device
> 
> Hi Yann,
> 
> looks like the patch was too large and majordomo ate it
> 
> Here is a link:
> 
> http://git.infradead.org/users/hch/rdma.git/commitdiff/0e46553467cd01b63ab9c985f87c18c5328880bb

Hey Christoph,

Can you create a series of smaller patches that will fit on the list?  That would make it easier for everyone to review/comment. 

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

message size, was Re: merge struct ib_device_attr into struct ib_device

['Christoph Hellwig']

On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote:
> Can you create a series of smaller patches that will fit on the list?
> That would make it easier for everyone to review/comment. 

I don't see how that is possible, as it's a flag day change.

But maybe we really need to bump up the message size limits for linux-rdma,
I'm pretty sure linux-kernel and linux-scsi handle attachments of this
size just fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

[Steve Wise]

> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of 'Christoph Hellwig'
> Sent: Tuesday, September 22, 2015 4:55 PM
> To: Steve Wise; postmaster-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: message size, was Re: merge struct ib_device_attr into struct ib_device
> 
> On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote:
> > Can you create a series of smaller patches that will fit on the list?
> > That would make it easier for everyone to review/comment.
> 
> I don't see how that is possible, as it's a flag day change.
> 
> But maybe we really need to bump up the message size limits for linux-rdma,
> I'm pretty sure linux-kernel and linux-scsi handle attachments of this
> size just fine.

An alternative, I guess, is to have the patch broken logically into a series by: core changes, driver changes, and ulp changes.  And
then ask Doug to squash it at merge time, as part of the cover letter.    But perhaps that isn't standard operating procedure...

How do we change the message size limits?   Reviewing w/o it being inline is painful for the (many) reviewers...

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

[David Miller]

From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Date: Tue, 22 Sep 2015 17:15:15 -0500

> How do we change the message size limits?  Reviewing w/o it being
> inline is painful for the (many) reviewers...

I've increased it.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: message size, was Re: merge struct ib_device_attr into struct ib_device

[Steve Wise]

> -----Original Message-----
> From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org]
> Sent: Tuesday, September 22, 2015 6:08 PM
> 
> > How do we change the message size limits?  Reviewing w/o it being
> > inline is painful for the (many) reviewers...
> 
> I've increased it.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

[Yann Droneaud]

Hi,

Le mardi 22 septembre 2015 à 23:55 +0200, 'Christoph Hellwig' a écrit :
> On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote:
> > Can you create a series of smaller patches that will fit on the
> > list?
> > That would make it easier for everyone to review/comment. 
> 
> I don't see how that is possible, as it's a flag day change.
> 

Perhaps you could change ib_query_device() to use the ib_device_attr
from struct ib_device so that ulp doesn't have to be modified at the
same time the drivers. Then further patches can update the users of
ib_query_device(), one at a time. And the last patch would remove
ib_query_device().

Regards.

-- 
Yann Droneaud

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

['Christoph Hellwig']

On Wed, Sep 23, 2015 at 10:26:38AM +0200, Yann Droneaud wrote:
> Perhaps you could change ib_query_device() to use the ib_device_attr
> from struct ib_device so that ulp doesn't have to be modified at the
> same time the drivers. Then further patches can update the users of
> ib_query_device(), one at a time. And the last patch would remove
> ib_query_device().

That would still leave us with a useless struct ib_device_attr embedded
into struct ib_device.  Anyway, I'll resend it now that the message limits have
been bumped.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html