Re: [PATCH rdma-core 04/10] providers: Use the new match_device and allocate_device ops

Jason Gunthorpe
2017-09-19T22:32:45Z

On Tue, Sep 19, 2017 at 04:29:17PM -0500, Steve Wise wrote:
> > + struct c4iw_dev *dev;
> > + struct hca_ent *hca_ent = sysfs_dev->provider_data;
> > +
> > + c4iw_page_size = sysconf(_SC_PAGESIZE);
> > + c4iw_page_shift = long_log2(c4iw_page_size);
> > + c4iw_page_mask = ~(c4iw_page_size - 1);
> >
> > c4iw_page_size = sysconf(_SC_PAGESIZE);
> > c4iw_page_shift = long_log2(c4iw_page_size);
> > c4iw_page_mask = ~(c4iw_page_size - 1);
>
>
> The above doesn't look right.

Oops, that is a rebasing-caused error I missed in this big series,
thank you I will correct it.

> Other than this, the cxgb bits look ok. Did you test it? ????

Not on cxgb, I tested other mlx4 and rxe to see that things were
working as expected. Since the matching code is now general that
covers a pretty big space..

Jason