Re: [PATCH rdma-core 04/10] providers: Use the new match_device and allocate_device ops

Jason Gunthorpe
2017-09-24T20:10:53Z

On Sun, Sep 24, 2017 at 01:44:58PM +0000, Amrani, Ram wrote:
> Please use qelr_ prefix for the functions.
> There shouldn't be any qedr in this file except for a comment, maybe.

I changed the series like so:

diff --git a/providers/qedr/qelr_main.c b/providers/qedr/qelr_main.c
index 1297e8e16acee5..fa2be455edc93e 100644
--- a/providers/qedr/qelr_main.c
+++ b/providers/qedr/qelr_main.c
@@ -223,7 +223,7 @@ static void qelr_free_context(struct ibv_context *ibctx)
free(ctx);
}

-static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev)
+static struct verbs_device *qelr_device_alloc(struct verbs_sysfs_dev *sysfs_dev)
{
struct qelr_device *dev;

@@ -235,11 +235,11 @@ static struct verbs_device *qedr_device_alloc(struct verbs_sysfs_dev *sysfs_dev)
}

static const struct verbs_device_ops qelr_dev_ops = {
- .name = "qelr",
+ .name = "qedr",
.match_min_abi_version = QELR_ABI_VERSION,
.match_max_abi_version = QELR_ABI_VERSION,
.match_table = hca_table,
- .alloc_device = qedr_device_alloc,
+ .alloc_device = qelr_device_alloc,
.uninit_device = qelr_uninit_device,
.alloc_context = qelr_alloc_context,
.free_context = qelr_free_context,

Jason