From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Jason Gunthorpe' <jgg-uk2M96/98Pc@public.gmane.org>,
'Potnuri Bharat Teja'
<bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug
Date: Tue, 19 Dec 2017 15:12:01 -0600 [thread overview]
Message-ID: <017901d3790e$030ddea0$09299be0$@opengridcomputing.com> (raw)
In-Reply-To: <20171219201639.GA14814-uk2M96/98Pc@public.gmane.org>
> On Tue, Dec 19, 2017 at 04:14:16PM +0530, Potnuri Bharat Teja wrote:
> > @@ -64,12 +64,6 @@
> > #define DRV_NAME "iw_cxgb4"
> > #define MOD DRV_NAME ":"
> >
> > -#ifdef pr_fmt
> > -#undef pr_fmt
> > -#endif
> > -
> > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > -
>
> Lots of other places in RDMA set a prefix, can we come to some agreement
if
> we
> should drop or keep this unverisally?
Either way we go, pr_fmt being redefined screws up pr_debug() which
optionally prepends the function, line, module names depending on the
dynamic debug settings. You end up with the module name embedded in the
middle of the log statement, and duplicated with +m is used. That is why
Bharat removed it from iw_cxgb4.
In general, I like module names in log statements, but we just need to do it
the right way to avoid the pr_debug issue...
steve
---
This email has been checked for viruses by AVG.
http://www.avg.com
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-19 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:44 [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug Potnuri Bharat Teja
[not found] ` <1513680256-8153-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2017-12-19 20:16 ` Jason Gunthorpe
[not found] ` <20171219201639.GA14814-uk2M96/98Pc@public.gmane.org>
2017-12-19 21:12 ` Steve Wise [this message]
2017-12-19 22:23 ` Jason Gunthorpe
[not found] ` <20171219222300.GH14814-uk2M96/98Pc@public.gmane.org>
2017-12-19 22:32 ` Steve Wise
2017-12-22 17:32 ` Jason Gunthorpe
[not found] ` <20171222173207.GF30884-uk2M96/98Pc@public.gmane.org>
2017-12-29 6:43 ` Potnuri Bharat Teja
[not found] ` <20171229064337.GA15043-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2017-12-29 18:09 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2017-12-19 10:08 Chelsio Cudbg
[not found] ` <1513678108-6634-1-git-send-email-chelsiocudbg-KJX8L1YACloTKYOLMXNBRxrm3jAUxWOA@public.gmane.org>
2017-12-19 10:14 ` Potnuri Bharat Teja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='017901d3790e$030ddea0$09299be0$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox