RE: [PATCH] RDMA/nes: Adding queue drain functions

["Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

> On Tue, Mar 29, 2016 at 03:49:18PM -0500, Steve Wise wrote:
> > >
> > > Adding sq and rq drain functions, which block until all
> > > previously posted wr-s in the specified queue have completed.
> > > A completion object is signaled to unblock the thread,
> > > when the last cqe for the corresponding queue is processed.
> > >
> > > Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > Looks good to me.  No locking needed though?
> >
> > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> 
> Steve,
> I see that this implementation follows your reference implementation of
> iw_cxgb4 which was iWARP specific. Can you point me to the relevant
> information which explain why this specific case exists?

The iWARP Verbs spec mandates that when the QP is in ERROR, post_send() and
post_recv() must, at some point, fail synchronously.  See:

http://tools.ietf.org/html/draft-hilland-rddp-verbs-00#section-6.2.4

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html