From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Leon Romanovsky' <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH RFC 2/2] RDMA/nldev: provide detailed CM_ID information
Date: Mon, 5 Feb 2018 11:06:25 -0600 [thread overview]
Message-ID: <01be01d39ea3$a7aae8d0$f700ba70$@opengridcomputing.com> (raw)
In-Reply-To: <20180205154351.GG2567-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
> > >
> > > It is opposite, cm_id is a unique number, but other objects don't have
> > > such. What about PD and CQ?
> > >
> > > We can declare that access to QP .doit willbe based on QPN, PD .doit
> > > will be based on local_dma_lkey, but what will be CQ identifier?
> > >
> >
> > Now that I've thought about this more, I realize the core verbs data
> > structures don't have identifiers for most objects. I'm not sure why
the
> > qp_num is exposed, but I guess it is because the qp num values must be
> > exchanged between both ends of an IB connection to setup the connection.
> >
> > The local_dma_lkey value will not be unique for each PD. For all
iwarp
> > devices the local_dma_lkey is 0. (I think the same is true for IB
devices).
> > So PD has the same issue as CQ.
> >
> > I suppose we can use rkey for MRs, but if the MR is not in the VALID
state,
> > the rkey isn't necessarily accurate (the LSB of the rkey can be changed
by
> > the application with each REG_MR operation).
> >
> > The cm_id doesn't have any unique identifier either, except maybe the
> > combination of src/dst addresses and port space.
> >
> > With iw_cxgb4, CQs, PDs, and MRs all have a unique identifier just like
a QP
> > does. I expect all hw implementations of rdma have numeric identifiers
for
> > CQs, PDs, QPs, etc. They aren't exposed to the core API though.
> >
> > Perhaps we add a device-unique (or globally unique) identifier as part
of
> > the restrack struct and use that for GET/SET?
>
> +1,
> I like it, it is very clean.
>
> Thanks
This should be done to a subsequent series. Perhaps when GET/SET are
actually implemented...
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-05 17:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 17:09 [PATCH RFC 0/2] cm_id resource tracking Steve Wise
[not found] ` <cover.1517418595.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2018-01-30 16:59 ` [PATCH RFC 1/2] RDMA/CM: move rdma_id_private into include/rdma/rdma_cm.h Steve Wise
[not found] ` <a85bb48eb9fc8846c81118a6777ab9ccbd27e9d7.1517418595.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2018-01-31 20:42 ` Parav Pandit
[not found] ` <VI1PR0502MB300809BAC31D5CBC0FA2311CD1FB0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-31 20:50 ` Steve Wise
2018-01-30 16:59 ` [PATCH RFC 2/2] RDMA/nldev: provide detailed CM_ID information Steve Wise
[not found] ` <531889e6a24f7919dec71734c91298d266aa9721.1517418595.git.swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2018-01-31 20:47 ` Parav Pandit
[not found] ` <VI1PR0502MB3008805F1A6056F50A12DEDBD1FB0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-01-31 20:56 ` Steve Wise
2018-01-31 21:18 ` Parav Pandit
[not found] ` <VI1PR0502MB30088B50BEA14B4C05EA2BC7D1FB0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2018-02-01 8:01 ` Leon Romanovsky
[not found] ` <20180201080109.GG2055-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-01 17:50 ` Jason Gunthorpe
[not found] ` <20180201175028.GS17053-uk2M96/98Pc@public.gmane.org>
2018-02-01 18:14 ` Steve Wise
2018-02-01 8:49 ` Leon Romanovsky
[not found] ` <20180201084944.GH2055-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-01 16:07 ` Steve Wise
2018-02-04 15:05 ` Leon Romanovsky
[not found] ` <20180204150553.GH27780-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-05 15:33 ` Steve Wise
2018-02-05 15:43 ` Leon Romanovsky
[not found] ` <20180205154351.GG2567-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-05 17:06 ` Steve Wise [this message]
2018-02-05 20:00 ` Jason Gunthorpe
[not found] ` <20180205200020.GH11446-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-05 20:28 ` Steve Wise
2018-02-05 20:36 ` Jason Gunthorpe
[not found] ` <20180205203608.GJ11446-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-05 20:53 ` Steve Wise
2018-02-05 21:16 ` Jason Gunthorpe
[not found] ` <20180205211618.GL11446-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-05 22:16 ` Steve Wise
2018-02-05 22:20 ` Jason Gunthorpe
[not found] ` <20180205222025.GC10095-uk2M96/98Pc@public.gmane.org>
2018-02-06 8:40 ` Leon Romanovsky
[not found] ` <20180206084019.GL2567-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-06 15:25 ` Jason Gunthorpe
2018-02-05 22:22 ` Steve Wise
2018-02-05 17:12 ` Steve Wise
2018-02-05 19:06 ` Steve Wise
2018-02-05 19:35 ` Steve Wise
2018-02-01 17:53 ` Jason Gunthorpe
[not found] ` <20180201175353.GU17053-uk2M96/98Pc@public.gmane.org>
2018-02-01 18:18 ` Steve Wise
2018-02-01 18:32 ` Jason Gunthorpe
[not found] ` <20180201183232.GV17053-uk2M96/98Pc@public.gmane.org>
2018-02-01 18:37 ` Steve Wise
2018-02-01 22:01 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01be01d39ea3$a7aae8d0$f700ba70$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).