From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH] Avoid possible hang on device removal Date: Tue, 25 Oct 2016 15:56:57 -0500 Message-ID: <01ec01d22f02$53012630$f9037290$@opengridcomputing.com> References: <1477428628-11504-1-git-send-email-mustafa.ismail@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1477428628-11504-1-git-send-email-mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Mustafa Ismail' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-rdma@vger.kernel.org > > When we get an RDMA_CM_EVENT_DEVICE_REMOVAL the cm_thread will > exit and because flush errors are ignored the cb->sem may not get signaled. > So just signal on device removal event. > > Signed-off-by: Mustafa Ismail Looks good. Reviewed-by: Steve Wise Also, this fixes a previous commit, so you could add this tag: Fixes 612eae1f6fe3 ("rping: ignore flushed completions") However that commit id is from the previous librdmacm repo...not sure how useful it is? Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html