From: Cosmin Ratiu <cratiu@nvidia.com>
To: Tariq Toukan <tariqt@nvidia.com>, "kuba@kernel.org" <kuba@kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Jiri Pirko <jiri@nvidia.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Carolina Jubran <cjubran@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>
Subject: Re: [PATCH net-next V4 08/14] devlink: Allow rate node parents from other devlinks
Date: Fri, 28 Nov 2025 09:57:07 +0000 [thread overview]
Message-ID: <020f1f6fb31320f963b308ed333918756dba0d42.camel@nvidia.com> (raw)
In-Reply-To: <20251127200928.65ce7349@kernel.org>
On Thu, 2025-11-27 at 20:09 -0800, Jakub Kicinski wrote:
> On Tue, 25 Nov 2025 22:06:07 +0200 Tariq Toukan wrote:
> > @@ -646,6 +706,13 @@ int devlink_nl_rate_set_doit(struct sk_buff
> > *skb, struct genl_info *info)
> > goto unlock;
> > }
> >
> > + if (info->user_ptr[1] && info->user_ptr[1] != devlink &&
> > + !ops->supported_cross_device_rate_nodes) {
> > + NL_SET_ERR_MSG(info->extack,
> > + "Cross-device rate parents aren't
> > supported");
> > + return -EOPNOTSUPP;
>
> err = ...
> goto unlock
Nice catch. Will fix.
Cosmin.
next prev parent reply other threads:[~2025-11-28 9:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 20:05 [PATCH net-next V4 00/14] devlink and mlx5: Support cross-function rate scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 01/14] devlink: Reverse locking order for nested instances Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 02/14] documentation: networking: add shared devlink documentation Tariq Toukan
2025-11-28 4:16 ` Jakub Kicinski
2025-11-28 11:00 ` Jiri Pirko
2025-11-29 3:19 ` Jakub Kicinski
2025-12-01 10:50 ` Jiri Pirko
2025-12-01 21:49 ` Jakub Kicinski
2025-12-02 7:43 ` Jiri Pirko
2025-12-02 18:14 ` Jakub Kicinski
2025-12-03 10:36 ` Jiri Pirko
2025-12-04 18:57 ` Jakub Kicinski
2025-12-05 9:39 ` Jiri Pirko
2025-11-25 20:06 ` [PATCH net-next V4 03/14] devlink: Add helpers to lock nested-in instances Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 04/14] devlink: Refactor devlink_rate_nodes_check Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 05/14] devlink: Decouple rate storage from associated devlink object Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 06/14] devlink: Add parent dev to devlink API Tariq Toukan
2025-11-27 15:28 ` Simon Horman
2025-11-27 19:18 ` Cosmin Ratiu
2025-11-25 20:06 ` [PATCH net-next V4 07/14] devlink: Allow parent dev for rate-set and rate-new Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 08/14] devlink: Allow rate node parents from other devlinks Tariq Toukan
2025-11-28 4:09 ` Jakub Kicinski
2025-11-28 9:57 ` Cosmin Ratiu [this message]
2025-11-25 20:06 ` [PATCH net-next V4 09/14] net/mlx5: Introduce shared devlink instance for PFs on same chip Tariq Toukan
2025-11-29 14:08 ` Krzysztof Kozlowski
2025-11-25 20:06 ` [PATCH net-next V4 10/14] net/mlx5: Expose a function to clear a vport's parent Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 11/14] net/mlx5: Store QoS sched nodes in the sh_devlink Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 12/14] net/mlx5: qos: Support cross-device tx scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 13/14] net/mlx5: qos: Enable cross-device scheduling Tariq Toukan
2025-11-25 20:06 ` [PATCH net-next V4 14/14] net/mlx5: Document devlink rates Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=020f1f6fb31320f963b308ed333918756dba0d42.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox