From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH rdma-next 1/2] RDMA: Simplify get firmware interface Date: Tue, 27 Jun 2017 09:39:32 -0500 Message-ID: <03a701d2ef53$30d560a0$928021e0$@opengridcomputing.com> References: <20170627140650.23510-1-leon@kernel.org> <20170627140650.23510-2-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170627140650.23510-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Leon Romanovsky' , 'Doug Ledford' Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Leon Romanovsky' List-Id: linux-rdma@vger.kernel.org > From: Leon Romanovsky > > There is a need to forward FW version to user space > application through RDMA netlink. In order to make it safe, there > is need to declare nla_policy and limit the size of FW string. > > The new define IB_FW_VERSION_NAME_MAX will limit the size of > FW version string. That define was chosen to be equal to > ETHTOOL_FWVERS_LEN, because many drivers anyway are limited > by that value indirectly. > > The introduction of this define allows us to remove the string size > from get_fw_str function signature. > > Signed-off-by: Leon Romanovsky cxgb* and core parts look good. Reviewed-by: Steve Wise -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html