From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Sagi Grimberg' <sagi@grimberg.me>,
'target-devel' <target-devel@vger.kernel.org>
Cc: linux-rdma@vger.kernel.org
Subject: RE: stuck iscsi/iser target with linux-4.15.0-rc1
Date: Mon, 18 Dec 2017 15:43:44 -0600 [thread overview]
Message-ID: <03bd01d37849$47497ae0$d5dc70a0$@opengridcomputing.com> (raw)
In-Reply-To: <1dee9f68-a81b-b7b8-9e70-e0ef5c63c520@grimberg.me>
> > [239800.115739] target_wait_for_sess_cmds: Waiting for se_cmd:
> ffff88034082c998 t_state: 6, fabric state: 12
>
> Hmm, this means that the command was delegated to isert to send
> data+response... Which means we lose a reference put somewhere here.
>
> I'm assuming that this happens before your changes to ib_drain_qp
> correct? If this does not happen without your changes it might indicate
> that drain_qp is missing an error (or successful?) completion which
> would prevent a final reference drop (isert_completion_put).
The issue doesn't happen on 4.15-rc4 with mlx4, but it does with cxgb4. There have been some bad problems with cxgb4's drain logic, so I need to just root cause this, because backing up to see if it used to work is problematic and will hit other issues with drain. The qp does get drained, and I confirmed it has no pending send or recv wrs. The associated cq's last 2 completions are from the ib_drain_qp() logic, so I need to somehow determine what completion got lost/dropped/whatever.
Do you have any thoughts on debugging this? Turning on isert debug is bad because the IO load is very high. I sort of need something that I can do after it gets stuck. So I can change the wait_for_completion() to a wait_for_completion_timeout() and if it times out, go figure out what it is stuck on.
---
This email has been checked for viruses by AVG.
http://www.avg.com
next prev parent reply other threads:[~2017-12-18 21:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 17:05 stuck iscsi/iser target with linux-4.15.0-rc1 Steve Wise
2017-12-03 13:29 ` Sagi Grimberg
[not found] ` <0ba7e891-f020-26fb-9945-9e824332593c-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-12-04 15:49 ` Steve Wise
2017-12-04 18:40 ` Sagi Grimberg
[not found] ` <1dee9f68-a81b-b7b8-9e70-e0ef5c63c520-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-12-13 21:40 ` Steve Wise
2017-12-13 22:34 ` Steve Wise
2017-12-13 22:35 ` Steve Wise
2017-12-18 16:32 ` Max Gurtovoy
[not found] ` <cbe1b731-8e37-884a-1406-6a7ca1f6a0be-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-18 17:12 ` Steve Wise
2017-12-18 21:43 ` Steve Wise [this message]
2017-12-19 21:53 ` Steve Wise
2017-12-19 22:21 ` Steve Wise
2017-12-21 8:08 ` Sagi Grimberg
2017-12-21 15:21 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03bd01d37849$47497ae0$d5dc70a0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).