From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@redhat.com" <davem@redhat.com>, "arnd@arndb.de" <arnd@arndb.de>
Cc: Aya Levin <ayal@mellanox.com>,
Shay Agroskin <shayag@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
Tariq Toukan <tariqt@mellanox.com>,
Maxim Mikityanskiy <maximmi@mellanox.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eran Ben Elisha <eranbe@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>,
"adhemerval.zanella@linaro.org" <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] mlx5: work around high stack usage with gcc
Date: Mon, 6 Jan 2020 21:59:30 +0000 [thread overview]
Message-ID: <057f4159f41b1d470d47a375435bc5afcb2c0261.camel@mellanox.com> (raw)
In-Reply-To: <20200106.133448.1654261172205332113.davem@redhat.com>
On Mon, 2020-01-06 at 13:34 -0800, David Miller wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> Date: Sat, 4 Jan 2020 22:51:44 +0100
>
> > In some configurations, gcc tries too hard to optimize this code:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function
> 'mlx5e_grp_sw_update_stats':
> > drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:302:1: error:
> the frame size of 1336 bytes is larger than 1024 bytes [-
> Werror=frame-larger-than=]
> >
> > As was stated in the bug report, the reason is that gcc runs into a
> corner
> > case in the register allocator that is rather hard to fix in a good
> way.
> >
> > As there is an easy way to work around it, just add a comment and
> the
> > barrier that stops gcc from trying to overoptimize the function.
> >
> > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92657
> > Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Saeed, please take this.
>
> Thank you.
>
Applied to net-next-mlx5
will submit to net-next later today.
Thanks !
prev parent reply other threads:[~2020-01-06 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 21:51 [PATCH] mlx5: work around high stack usage with gcc Arnd Bergmann
2020-01-06 21:34 ` David Miller
2020-01-06 21:59 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=057f4159f41b1d470d47a375435bc5afcb2c0261.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=ayal@mellanox.com \
--cc=davem@redhat.com \
--cc=eranbe@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maximmi@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=shayag@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox