public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Jason Gunthorpe'
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH rdma-core 2/4] providers: Make every provider allocate a verbs_device
Date: Wed, 1 Mar 2017 14:01:29 -0600	[thread overview]
Message-ID: <069201d292c6$9d91be80$d8b53b80$@opengridcomputing.com> (raw)
In-Reply-To: <1488317497-538-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

> Switch struct ibv_device to verbs_device in the provider specific device
> structure and use calloc to allocate it so the unset bytes are zero.
> 
> This lets us change the return type of ibv_driver_init_func to
> struct verbs_device without changing the control flow at all.
> 
> Also make a few _init functions static for consistency/simplicity.
> 
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

cxgb* changes look fine.

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-03-01 20:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 21:31 [PATCH rdma-core 0/4] Cleanup ibv_register_driver Jason Gunthorpe
     [not found] ` <1488317497-538-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-02-28 21:31   ` [PATCH rdma-core 1/4] ibverbs: Make struct verbs_device and related private Jason Gunthorpe
2017-02-28 21:31   ` [PATCH rdma-core 2/4] providers: Make every provider allocate a verbs_device Jason Gunthorpe
     [not found]     ` <1488317497-538-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-03-01 20:01       ` Steve Wise [this message]
2017-02-28 21:31   ` [PATCH rdma-core 3/4] providers: Move all verbs_device ops into struct verbs_device_ops Jason Gunthorpe
2017-02-28 21:31   ` [PATCH rdma-core 4/4] verbs: Remove ibv_register_driver Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='069201d292c6$9d91be80$d8b53b80$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox