RE: [PATCHv1 1/1] IB/iser: Fix sg_tablesize calculation

["Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

> > diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c
> b/drivers/infiniband/ulp/iser/iscsi_iser.c
> > index 9104e6b..ff37f19 100644
> > --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> > +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> > @@ -656,7 +656,8 @@ static void iscsi_iser_cleanup_task(struct iscsi_task
*task)
> >  		 * max fastreg page list length.
> >  		 */
> 
> Hi Max,
> 
> >  		shost->sg_tablesize = min_t(unsigned short, shost->sg_tablesize,
> > -			ib_conn->device->ib_device-
> >attrs.max_fast_reg_page_list_len);
> > +				      min_t(unsigned int, USHRT_MAX,
> > +			ib_conn->device->ib_device-
> >attrs.max_fast_reg_page_list_len));
> 
> Hmm, This looks broken since I fixed up mlx5 capability at:
> 911f4331bc87 ("IB/mlx5: Expose correct max_fast_reg_page_list_len")
> 
> However, I suspect this assignment should be removed altogether because
> we already take that into account in the address resolution handler,
> there the min statement is for unsigned and casted back to ushrt.

Hey Sagi, where is the code to which you refer?   "address resolution handler?"

Thanks,

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html