From: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
To: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Monjalon <thomasm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC PATCH rdma-core] Check that public headers support -Wpedantic
Date: Fri, 9 Feb 2018 10:46:27 -0800 [thread overview]
Message-ID: <073d4608-cfe3-c40a-df76-648b1ae40318@wdc.com> (raw)
In-Reply-To: <20180209181410.GA15016-uk2M96/98Pc@public.gmane.org>
On 02/09/18 10:14, Jason Gunthorpe wrote:
> +static inline struct verbs_context *_verbs_get_ctx_op(struct ibv_context *ctx,
> + size_t op_off)
> +{
> + struct verbs_context *vctx = verbs_get_ctx(ctx);
> + void *op;
> + if (!vctx)
> + return NULL;
> +
> + if (vctx->sz < sizeof(*vctx) - op_off)
> + return NULL;
> +
> + op = *((void **)((uint8_t *)vctx) + op_off);
Something really minor: I think there are more parentheses in the above
expression than strictly needed. Otherwise this patch looks fine to me.
Thanks,
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-09 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 18:14 [RFC PATCH rdma-core] Check that public headers support -Wpedantic Jason Gunthorpe
[not found] ` <20180209181410.GA15016-uk2M96/98Pc@public.gmane.org>
2018-02-09 18:46 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073d4608-cfe3-c40a-df76-648b1ae40318@wdc.com \
--to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thomasm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).