Re: [PATCH 08/28] bnxt_re: Add bnxt_re RoCE driver files

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 4093 bytes --]

On 12/5/2016 1:38 AM, Selvin Xavier wrote:

> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index fb3fb89..a4fab22 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -91,4 +91,6 @@ source "drivers/infiniband/hw/hfi1/Kconfig"
>  
>  source "drivers/infiniband/hw/qedr/Kconfig"
>  
> +source "drivers/infiniband/hw/bnxtre/Kconfig"
> +
>  endif # INFINIBAND
> diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
> index e7a5ed9..7227b36 100644
> --- a/drivers/infiniband/hw/Makefile
> +++ b/drivers/infiniband/hw/Makefile
> @@ -11,3 +11,4 @@ obj-$(CONFIG_INFINIBAND_USNIC)		+= usnic/
>  obj-$(CONFIG_INFINIBAND_HFI1)		+= hfi1/
>  obj-$(CONFIG_INFINIBAND_HNS)		+= hns/
>  obj-$(CONFIG_INFINIBAND_QEDR)		+= qedr/
> +obj-$(CONFIG_INFINIBAND_BNXTRE)		+= bnxtre/
> diff --git a/drivers/infiniband/hw/bnxtre/Kconfig b/drivers/infiniband/hw/bnxtre/Kconfig
> new file mode 100644
> index 0000000..2637544
> --- /dev/null
> +++ b/drivers/infiniband/hw/bnxtre/Kconfig
> @@ -0,0 +1,9 @@
> +config INFINIBAND_BNXTRE
> +    tristate "Broadcom Netxtreme HCA support"
> +    depends on ETHERNET && NETDEVICES && PCI && INET
> +    select NET_VENDOR_BROADCOM
> +    select BNXT
> +    ---help---
> +	  This driver supports Broadcom NetXtreme-C/E 10/25/40/50 gigabit
> +	  RoCE HCAs.  To compile this driver as a module, choose M here:
> +	  the module will be called bnxt_re.
> diff --git a/drivers/infiniband/hw/bnxtre/Makefile b/drivers/infiniband/hw/bnxtre/Makefile
> new file mode 100644
> index 0000000..0521489
> --- /dev/null
> +++ b/drivers/infiniband/hw/bnxtre/Makefile
> @@ -0,0 +1,5 @@
> +
> +obj-$(CONFIG_INFINIBAND_BNXTRE) += bnxt_re.o
> +bnxt_re-y := bnxt_re_main.o bnxt_re_ib_verbs.o \
> +	     bnxt_qplib_res.o bnxt_qplib_rcfw.o	\
> +	     bnxt_qplib_sp.o bnxt_qplib_fp.o

A lot of times I prefer these files to be the final patch in the series.
 It's completely not possible to break bisectability if these are last.
Then again, if I squash this down to one commit it doesn't really matter....

> diff --git a/drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c b/drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c
> new file mode 100644
> index 0000000..34873f4
> --- /dev/null
> +++ b/drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c
> @@ -0,0 +1,12 @@
> +/* Broadcom NetXtreme-C/E RoCE driver.
> + *
> + * Copyright (c) 2016 Broadcom Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation.
> + */

This copyright, repeated many times in the various skeleton files...

> diff --git a/drivers/infiniband/hw/bnxtre/bnxt_re_main.c b/drivers/infiniband/hw/bnxtre/bnxt_re_main.c
> new file mode 100644
> index 0000000..4c377dc
> --- /dev/null
> +++ b/drivers/infiniband/hw/bnxtre/bnxt_re_main.c
> @@ -0,0 +1,96 @@
> +/* Broadcom NetXtreme-C/E RoCE driver.
> + *
> + * Copyright (c) 2016 Broadcom Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation.
> + */
> +
> +/*
> + * Description: Main component of the bnxt_re driver
> + */
> +
> +#include <linux/module.h>
> +#include <linux/netdevice.h>
> +#include <linux/mutex.h>
> +#include <linux/list.h>
> +#include <linux/rculist.h>
> +#include "bnxt_re.h"
> +static char version[] =
> +		BNXT_RE_DESC " v" ROCE_DRV_MODULE_VERSION "\n";
> +
> +
> +MODULE_AUTHOR("Eddie Wai <eddie.wai-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>");
> +MODULE_DESCRIPTION(BNXT_RE_DESC " Driver");
> +MODULE_LICENSE("Dual BSD/GPL");

and this module license description do not agree.  Please make
everything consistent.  I don't care if it's GPLv2 or Dual licensed, it
simply needs to be consistent.




-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]