From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>,
Zhu Yanjun <yanjun.zhu@linux.dev>,
Jason Gunthorpe <jgg@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Cc: linux-rdma@vger.kernel.org,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] RDMA/srpt: Make slab cache names unique
Date: Mon, 7 Oct 2024 10:28:13 -0600 [thread overview]
Message-ID: <09aa620c-b44b-41d2-a207-d2cc477fdad2@kernel.dk> (raw)
In-Reply-To: <09ffcd22-8853-4bb3-8471-ef620303174b@acm.org>
On 10/7/24 10:14 AM, Bart Van Assche wrote:
> On 10/7/24 7:06 AM, Jens Axboe wrote:
>> Still seems way over engineered, just use an atomic_long_t for a
>> continually increasing index number.
>
> Even an atomic_long_t can wrap around and hence can result in duplicate
> slab cache names. With my patch it is guaranteed that slab cache names
> are unique. I'm not claiming that this patch is the best possible
> solution but it's a working solution and a solution that doesn't require
> too many changes to the ib_srpt driver.
Come on... The current patch doesn't even check if ida_alloc() got an ID.
Without that, using some mechanism to alloc+free an index is surely less
than useful.
--
Jens Axboe
next prev parent reply other threads:[~2024-10-07 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 17:37 [PATCH] RDMA/srpt: Make slab cache names unique Bart Van Assche
2024-10-07 2:44 ` Shinichiro Kawasaki
2024-10-07 9:51 ` Zhu Yanjun
2024-10-07 14:06 ` Jens Axboe
2024-10-07 16:14 ` Bart Van Assche
2024-10-07 16:28 ` Jens Axboe [this message]
2024-10-07 16:52 ` Bart Van Assche
2024-10-07 16:55 ` Jason Gunthorpe
2024-10-07 17:16 ` Bart Van Assche
2024-10-07 17:20 ` Jens Axboe
2024-10-07 17:22 ` Jason Gunthorpe
2024-10-07 17:25 ` Jens Axboe
2024-10-07 16:11 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09aa620c-b44b-41d2-a207-d2cc477fdad2@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox