From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: Andrea Parri <andrea.parri@amarulasolutions.com>,
"Ruhl, Michael J" <michael.j.ruhl@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 5/5] IB/hfi1: Fix improper uses of smp_mb__before_atomic()
Date: Tue, 14 May 2019 08:32:52 -0400 [thread overview]
Message-ID: <0a78eded-6c08-8d32-ec31-d62d6feb2118@intel.com> (raw)
In-Reply-To: <20190509211221.GA4966@andrea>
On 5/9/2019 5:12 PM, Andrea Parri wrote:
> On Tue, Apr 30, 2019 at 01:16:57AM +0200, Andrea Parri wrote:
>> Hi Mike,
>>
>>>> This barrier only applies to the read-modify-write operations; in
>>>> particular, it does not apply to the atomic_read() primitive.
>>>>
>>>> Replace the barrier with an smp_mb().
>>>
>>> This is one of a couple of barrier issues that we are currently looking into.
>>>
>>> See:
>>>
>>> [PATCH for-next 6/9] IB/rdmavt: Add new completion inline
>>>
>>> We will take a look at this one as well.
>>
>> Thank you for the reference and for looking into this,
>
> So, I'm planning to just drop this patch; or can I do something to help?
>
> Please let me know.
Mike was looking into this, and I've got a handful of patches from him
to review. He's unavailable for a while but if it's not included in the
patches I've got we'll get something out shortly. So yes I think we can
hold off on this patch for now. Thanks.
-Denny
next prev parent reply other threads:[~2019-05-14 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1556568902-12464-1-git-send-email-andrea.parri@amarulasolutions.com>
2019-04-29 20:15 ` [PATCH 5/5] IB/hfi1: Fix improper uses of smp_mb__before_atomic() Andrea Parri
2019-04-29 21:24 ` Ruhl, Michael J
2019-04-29 23:16 ` Andrea Parri
2019-05-09 21:12 ` Andrea Parri
2019-05-14 12:32 ` Dennis Dalessandro [this message]
2019-05-14 14:48 ` Andrea Parri
2019-04-30 8:28 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a78eded-6c08-8d32-ec31-d62d6feb2118@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.j.ruhl@intel.com \
--cc=mike.marciniszyn@intel.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox