From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A4AC433FE for ; Fri, 28 Jan 2022 14:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244797AbiA1OFr (ORCPT ); Fri, 28 Jan 2022 09:05:47 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:49305 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344330AbiA1OFr (ORCPT ); Fri, 28 Jan 2022 09:05:47 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R291e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=alibuda@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0V32e-ng_1643378739; Received: from 192.168.1.13(mailfrom:alibuda@linux.alibaba.com fp:SMTPD_---0V32e-ng_1643378739) by smtp.aliyun-inc.com(127.0.0.1); Fri, 28 Jan 2022 22:05:40 +0800 Message-ID: <0b88ed12-4f04-6c71-7210-98a71041f5cc@linux.alibaba.com> Date: Fri, 28 Jan 2022 22:05:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH net-next 3/3] net/smc: Fallback when handshake workqueue congested To: Matthieu Baerts , kgraul@linux.ibm.com Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, MPTCP Upstream References: <1825f5e8-6d13-a317-4a96-f4a4fcf07409@tessares.net> From: "D. Wythe" In-Reply-To: <1825f5e8-6d13-a317-4a96-f4a4fcf07409@tessares.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Sorry for this mistake。 Thanks for your pointing out. Thanks again. 在 2022/1/28 上午1:09, Matthieu Baerts 写道: > Hi, > > (+cc MPTCP ML) > > On 27/01/2022 13:08, D. Wythe wrote: >> From: "D. Wythe" >> >> This patch intends to provide a mechanism to allow automatic fallback to >> TCP according to the pressure of SMC handshake process. At present, >> frequent visits will cause the incoming connections to be backlogged in >> SMC handshake queue, raise the connections established time. Which is >> quite unacceptable for those applications who base on short lived >> connections. > > (...) > >> diff --git a/net/smc/Kconfig b/net/smc/Kconfig >> index 1ab3c5a..1903927 100644 >> --- a/net/smc/Kconfig >> +++ b/net/smc/Kconfig >> @@ -19,3 +19,15 @@ config SMC_DIAG >> smcss. >> >> if unsure, say Y. >> + >> +if MPTCP > > After having read the code and the commit message, it is not clear to me > why this new feature requires to have MPTCP enabled. May you share some > explanations about that please? > >> + >> +config SMC_AUTO_FALLBACK >> + bool "SMC: automatic fallback to TCP" >> + default y >> + help >> + Allow automatic fallback to TCP accroding to the pressure of SMC-R >> + handshake process. >> + >> + If that's not what you except or unsure, say N. >> +endif > > Cheers, > Matt