From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Anand Khoje <anand.a.khoje@oracle.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <saeedm@mellanox.com>, <leon@kernel.org>, <tariqt@nvidia.com>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<davem@davemloft.net>
Subject: Re: [PATCH v5] net/mlx5: Reclaim max 50K pages at once
Date: Mon, 24 Jun 2024 13:41:17 -0700 [thread overview]
Message-ID: <0b926745-f2c9-4313-a874-4b7e059b8d64@intel.com> (raw)
In-Reply-To: <20240624153321.29834-1-anand.a.khoje@oracle.com>
On 6/24/2024 8:33 AM, Anand Khoje wrote:
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> @@ -608,6 +608,7 @@ enum {
> RELEASE_ALL_PAGES_MASK = 0x4000,
> };
>
> +#define MAX_RECLAIM_NPAGES -50000
Can you please explain why this is negative? There doesn't seem to be
any reason mentioned in the commit message or code.
At the very least it's super confusing to have a MAX be negative, and at
worst it's a bug. I don't have any other context on this code besides
this patch, so an explanation would be helpful.
next prev parent reply other threads:[~2024-06-24 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 15:33 [PATCH v5] net/mlx5: Reclaim max 50K pages at once Anand Khoje
2024-06-24 20:41 ` Jesse Brandeburg [this message]
2024-06-25 5:00 ` Anand Khoje
2024-06-25 20:19 ` Zhu Yanjun
2024-06-26 5:34 ` Leon Romanovsky
2024-06-28 15:44 ` David Laight
2024-07-01 5:39 ` Anand Khoje
2024-07-01 5:40 ` Anand Khoje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b926745-f2c9-4313-a874-4b7e059b8d64@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=anand.a.khoje@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@mellanox.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox