From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Leon Romanovsky' <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
'Artemy Kovalyov'
<artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
'Selvin Xavier'
<selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
'Steve Wise' <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
'Lijun Ou' <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
'Shiraz Saleem'
<shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Adit Ranadive' <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
'Dennis Dalessandro'
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Ram Amrani' <Ram.Amrani-74tsMCuadCbQT0dZR+AlfA@public.gmane.org>
Subject: RE: [PATCH rdma-next 01/10] IB: Replace ib_umem page_size by page_shift
Date: Wed, 5 Apr 2017 10:30:11 -0500 [thread overview]
Message-ID: <0c8601d2ae21$8441bc20$8cc53460$@opengridcomputing.com> (raw)
In-Reply-To: <20170403100640.3332-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> From: Artemy Kovalyov <artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Size of pages are held by struct ib_umem in page_size field.
>
> It is better to store it as an exponent, because page size by nature
> is always power-of-two and used as a factor, divisor or ilog2's argument.
>
> The conversion of page_size to be page_shift allows to have portable
> code and avoid following error while compiling on ARM:
>
> ERROR: "__aeabi_uldivmod" [drivers/infiniband/core/ib_core.ko]
> undefined!
>
> CC: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> CC: Steve Wise <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> CC: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> CC: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> CC: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
> CC: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> CC: Ram Amrani <Ram.Amrani-74tsMCuadCbQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Artemy Kovalyov <artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/core/umem.c | 15 ++++++---------
> drivers/infiniband/core/umem_odp.c | 12 ++++++------
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 12 ++++++------
> drivers/infiniband/hw/cxgb3/iwch_provider.c | 4 ++--
> drivers/infiniband/hw/cxgb4/mem.c | 4 ++--
For the cxgb parts:
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-05 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 10:06 [PATCH rdma-next 00/10] ODP Fixes and Improvements Leon Romanovsky
[not found] ` <20170403100640.3332-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-03 10:06 ` [PATCH rdma-next 01/10] IB: Replace ib_umem page_size by page_shift Leon Romanovsky
[not found] ` <20170403100640.3332-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-04-04 22:57 ` Shiraz Saleem
[not found] ` <20170404225723.GA12652-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-04-05 6:11 ` Leon Romanovsky
2017-04-05 15:30 ` Steve Wise [this message]
2017-04-03 10:06 ` [PATCH rdma-next 02/10] IB/mlx5: Fix function updating xlt emergency path Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 03/10] IB/mlx5: Fix UMR size calculation Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 04/10] IB/mlx5: Fix implicit MR GC Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 05/10] IB/mlx5: Decrease verbosity level of ODP errors Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 06/10] IB/umem: Add contiguous ODP support Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 07/10] IB/mlx5: " Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 08/10] IB/umem: Add support to huge ODP Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 09/10] IB/mlx5: Extract page fault code Leon Romanovsky
2017-04-03 10:06 ` [PATCH rdma-next 10/10] IB/mlx5: Add ODP support to MW Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0c8601d2ae21$8441bc20$8cc53460$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=Ram.Amrani-74tsMCuadCbQT0dZR+AlfA@public.gmane.org \
--cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).