From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Dennis Dalessandro <dennis.dalessandro@intel.com>,
linux-rdma@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Yishai Hadas <yishaih@mellanox.com>,
Yuval Shaia <yuval.shaia@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()
Date: Fri, 27 Oct 2017 09:34:18 +0200 [thread overview]
Message-ID: <0c92fc8e-ecb8-c7ed-0b4c-721752297222@users.sourceforge.net> (raw)
In-Reply-To: <70843f43-03c5-8295-643a-4f228ff2e907@intel.com>
>> Add a jump target so that a bit of exception handling can be better reused
>> at the end of this function.
>
> I'm not sure this is that big of a win.
Such a view is appropriate because I proposed just another small adjustment
for this source code place.
> I mean you aren't really making the code any smaller
Would anybody like to check corresponding effects in more detail
after a specific function call was replaced by a goto statement?
> and it's not making it any easier to read really.
Is the code readability still good enough there?
Regards,
Markus
next prev parent reply other threads:[~2017-10-27 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 16:12 [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow() SF Markus Elfring
2017-10-27 0:33 ` Dennis Dalessandro
2017-10-27 7:34 ` SF Markus Elfring [this message]
[not found] ` <0c92fc8e-ecb8-c7ed-0b4c-721752297222-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-10-27 19:36 ` Leon Romanovsky
[not found] ` <20171027193601.GI16127-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-30 8:04 ` SF Markus Elfring
[not found] ` <e2febce9-4b80-a40e-024e-5c24964301ac-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-10-30 8:34 ` Leon Romanovsky
2017-10-30 8:47 ` SF Markus Elfring
[not found] ` <70843f43-03c5-8295-643a-4f228ff2e907-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-27 19:44 ` [PATCH] " Leon Romanovsky
2017-10-27 19:39 ` Leon Romanovsky
2017-10-27 20:53 ` SF Markus Elfring
2017-10-27 21:54 ` Dennis Dalessandro
2017-10-28 7:39 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c92fc8e-ecb8-c7ed-0b4c-721752297222@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox