Re: [PATCH rdma-core 1/2] srp_daemon: handle SM lid change

Dennis Dalessandro
2017-12-13T11:32:30Z

On 12/12/2017 9:08 AM, Nicolas Morey-Chaisemartin wrote:
> When srp_daemon was running and the master SM host changes,
> srp_daemon output these errors at every scan:
> srp_daemon[25394]: No response to inform info registration
> srp_daemon[25394]: Fail to register to traps, maybe there is no opensm
> running on fabric or IB port is down
>
> This was introduced by commit 4952e5f Fix a memory leak.
> A side effect of this patch was that create_ah was only called when the
> port lid changes. Which meant register_to_traps used an older, obsolete,
> version of sm_lid and failed to connect to it.
>
> This patch fixes this behaviour by checking for both local lid changes and
> SM lid changes, and calling create_ah on any of these events.
>
> Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin-IBi9RG/b67k@public.gmane.org>
> Cc: stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org # v14, v15, v16

You are probably going to want to add a proper fixes tag here rather
than just mentioning in the commit messages.

Fixes: <12-char-of-SHA> ("Patch subject")

-Denny