Re: [PATCH rdma-core 1/2] srp_daemon: handle SM lid change

Leon Romanovsky
2017-12-19T05:46:47Z

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Wed, Dec 13, 2017 at 06:32:30AM -0500, Dennis Dalessandro wrote:
> On 12/12/2017 9:08 AM, Nicolas Morey-Chaisemartin wrote:
> > When srp_daemon was running and the master SM host changes,
> > srp_daemon output these errors at every scan:
> > srp_daemon[25394]: No response to inform info registration
> > srp_daemon[25394]: Fail to register to traps, maybe there is no opensm
> > running on fabric or IB port is down
> >
> > This was introduced by commit 4952e5f Fix a memory leak.
> > A side effect of this patch was that create_ah was only called when the
> > port lid changes. Which meant register_to_traps used an older, obsolete,
> > version of sm_lid and failed to connect to it.
> >
> > This patch fixes this behaviour by checking for both local lid changes and
> > SM lid changes, and calling create_ah on any of these events.
> >
> > Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin-IBi9RG/b67k@public.gmane.org>
> > Cc: stable-Xl5UnYtxxKxKUA01WzcqbQ@public.gmane.org # v14, v15, v16

There is no need to mention all versions, it is enough to write first one.

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]