From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5D036897F for ; Fri, 31 Jul 2026 12:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785501691; cv=none; b=YMq68uwLzQJysjBS0n4PBMmNDSxPBjFy1qhAGShmeo5P/4pRj3Yvqchmf8CqGFqcOqpUmUGzfjTpf4k0qtMDoV0U19vaDRcrw+CQ4oibpC88y+OS3MLALYCHwcWnSnaZa0IPsLaAjsCbdr16k0eEJV/3/lMPQfAfl6YHDD639xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785501691; c=relaxed/simple; bh=keIsujryx3Uee0mJit7AKr9nN0ssqKTbSC5x1osOq28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CEGznUgWsobVf7dst9b6Xhhx1igcRuXterCa8epMFaZMDj5ePn5BPEhwsc38yvjTCVQNGvVsnTgKMhdpQ2gFRj85Ukn6PgdfyIc71vt2/VZrq9rxRGANgH+HkRs4S58vVdSzqLL35aRUpKHypYFx8AqOAvJgjfy5vTJaWfoIKdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i6nafXas; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i6nafXas" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-907ae240ac3so4614456d6.0 for ; Fri, 31 Jul 2026 05:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785501689; x=1786106489; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AR51AZn/bvW2dwxRSuHfDMRFFtyWMfnouj4EfaRrzZs=; b=i6nafXasKXLG6nPUYRVBnBIWDGnj99S2pyfmAT2SMCWXhLDV8XaYrouc2Ua2i5vimd UUXEjqOji+58UkOqKxSbvC33VFKvxw7L4sGbacPAUAIXlq80E19WLzwA8qQSPeKkl2r3 Z9XqISG1mtM7UD2DkFdMqLsP8GKgKzA4FQXBHQ/65SNEeMqkq9dpzySYFRhCkLpiKTfu ODht7ZlfQdd1TZGhwUwP/AR8ys9xgWE3iHFC1f2kHvvhkYNIsLfG5clzN29EaXwMEkls JYIOd1M+Gu+c/ZQzbbF3RPRyK9jEqIQ80Vzk20y6O2vdK7enadd2F4bGmXY/EJFU3KIq e9AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785501689; x=1786106489; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AR51AZn/bvW2dwxRSuHfDMRFFtyWMfnouj4EfaRrzZs=; b=Y9GwHsgky5VVbF92FqWfEMvoCT1al9i4S5hIewK7YFZXSc9BGc6GmwJhSX6K2U8vMs 9fHAcfZFcxLq+5zQsJVzVbW38GnPeQmoDJtRoIPD007vwh+OIoBgr1wr3y3+E940p7/M Jf4GAHwdQ4pN3yFOFe96ef09FudUBFI7Js4sl8ZMNZWh9tw3i+47w9f3PuojVi3qvL7v FEM4ecNZ1w+lEakG0nvYmlW2j4BlcwE/fuJlWq/JHEyuMGvqVYh4dOwQF8PJQFHSVWpH 4l1rE+vn76RrjVBi6gZHRtDXH87wAPHpHeEytQGErG1G7dKr220gavK3qqvdItPA9d9E zTDg== X-Forwarded-Encrypted: i=1; AHgh+Rp63KvXmBT1kdNgb53WpqdGSJD6S2V3fwBuJmXKVukCICBFPK0EwM5UsWEfqCFIxeRNCyRiaJVmRXTK@vger.kernel.org X-Gm-Message-State: AOJu0Yx442BH7C9vVw2IbA6/Tnq6RJknt5i3WUAxBsYmVgrA8SiLlBfr wronpjcFYr7Vll4YDxNv9ZmbSPruwHMfUJ6Gth0uWpZVHnn4uaON9h7u X-Gm-Gg: AR+sD10lLdlYysOXYRvUAGwP4ebrSa3AhunZFFme0/ZlkZ3A3/YAYnsmqXqSPJn3Rm3 3KhjLbOkvvWxaT3U7yuVNyJTfjmZQP7eWItRgiORBaGzYcA8br4dEwOalBmD98MbMTOaH84QZp2 2pG2jUeSfEqwy+wXAz7P14u18S8/9svCUFKUrNsyd8yh+w/IhXKOUaev3jOfAMx4GS6cfLkYYev RKdCVZvP5F9c/ZlcvMs1cTHHNSWZGtVg/Bwg6G7yfZ01j/vUJfOsf6vxUrKeTFcqrbHoS/SanMz lvNhwWiSd+EFWoQDb/DiMemEQew62QSXFS81Km5PquGEM/YW20y+ECuTkKAHLRSA8/pXRLY2hQN Uq4FFwgFnnEe7WtUwMELY7JO3s8c0FS7NoaysU4DaYJBAsl1FIG0z1qScJH+6q3grO1WGJAmMp9 MTh4OEKOCItFOvo0vTGIuIQaZ4bqfzhSWq9Md334DYqTraeocbTGfRIg9/UR30iBZv6hYZmmy4E gxD5CgbfgPbdUhd3Gw+2oURdkexEzQ= X-Received: by 2002:a05:6214:3f85:b0:8ef:91c5:8edb with SMTP id 6a1803df08f44-9084218e7a2mr38156866d6.10.1785501688541; Fri, 31 Jul 2026 05:41:28 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1145:4:4e58:3e50:ad11:4e7a? ([2620:10d:c091:500::4:2e2b]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435dfa6dsm9313106d6.33.2026.07.31.05.41.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 05:41:27 -0700 (PDT) Message-ID: <0d72c5b2-6d4c-40d4-8cbe-8cd95d61a230@gmail.com> Date: Fri, 31 Jul 2026 08:41:26 -0400 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/13] net/mlx5e: psp: Add an rx_decap steering table To: Tariq Toukan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, Paolo Abeni , Sabrina Dubroca Cc: Aleksandr Loktionov , Alexei Lazar , Boris Pismenny , Carolina Jubran , Chris Mi , Cosmin Ratiu , Doruk Tan Ozturk , Dragos Tatulea , Gal Pressman , Jacob Keller , Jianbo Liu , Kees Cook , Lama Kayal , Leon Romanovsky , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Bloch , Patrisious Haddad , Raed Salem , Rahul Rameshbabu , Saeed Mahameed , Shuah Khan , Shuah Khan , Simon Horman , Stanislav Fomichev , Stanislav Fomichev References: <20260730091756.2543777-1-tariqt@nvidia.com> <20260730091756.2543777-10-tariqt@nvidia.com> Content-Language: en-US From: Daniel Zahka In-Reply-To: <20260730091756.2543777-10-tariqt@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/30/26 5:17 AM, Tariq Toukan wrote: > +static > +void accel_psp_fs_rx_decap_ft_destroy(struct mlx5e_psp_fs *fs, > + struct mlx5e_psp_rx_decap_table *decap) > +{ > + int i; > + > + accel_psp_fs_del_flow_rule(&decap->unsupported_rule); > + for (i = 0; i < MLX5E_PSP_NUM_SUPPORTED_VERSIONS; i++) > + accel_psp_fs_del_flow_rule(&decap->rule[i]); > + if (decap->reformat) { > + mlx5_packet_reformat_dealloc(fs->mdev, decap->reformat); > + decap->reformat = NULL; > + } > + accel_psp_fs_dealloc_modify_hdr(fs->mdev, &decap->modify_hdr); > + accel_psp_fs_destroy_flow_group(&decap->drop_group); > + accel_psp_fs_destroy_ft(&decap->ft); > +} > + [...] > +static int accel_psp_fs_rx_reconfigure(struct mlx5e_psp_fs *fs, > + bool decap_wanted) > +{ > + bool decap_supported = > + MLX5_CAP_FLOWTABLE(fs->mdev, > + flow_table_properties_nic_receive.reformat_del_psp_transport); > + bool decap_enable = decap_wanted && decap_supported; > + struct mlx5_flow_destination dest = {}; > + int err; > + > + /* Create the decap table if needed. */ > + if (decap_enable && !fs->decap.ft) { > + err = accel_psp_fs_rx_decap_ft_create(fs, &fs->decap); > + if (err) { > + mlx5_core_warn(fs->mdev, > + "Failed to create PSP decapsulation rules (err %d), HW GRO for PSP unavailable", > + err); > + decap_enable = false; > + } > + } > + if (decap_enable == fs->decap_enabled) > + return 0; An llm is complaining that fs->decap_enabled is not set to false when the decap table is destroyed with accel_psp_fs_rx_decap_ft_destroy(), which would cause problems after doing a psp_dev_ops::set_config() down and up. I'm not sure if this is legit, but figured I would flag it as it seems plausible and would be easily reachable by a user.