From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A50C433B4 for ; Tue, 6 Apr 2021 13:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BA4A613B8 for ; Tue, 6 Apr 2021 13:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243884AbhDFN31 convert rfc822-to-8bit (ORCPT ); Tue, 6 Apr 2021 09:29:27 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:3331 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231919AbhDFN31 (ORCPT ); Tue, 6 Apr 2021 09:29:27 -0400 Received: from dggeml405-hub.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FF7ZM5dm6z14D5B; Tue, 6 Apr 2021 21:25:47 +0800 (CST) Received: from dggema701-chm.china.huawei.com (10.3.20.65) by dggeml405-hub.china.huawei.com (10.3.17.49) with Microsoft SMTP Server (TLS) id 14.3.498.0; Tue, 6 Apr 2021 21:29:15 +0800 Received: from dggema753-chm.china.huawei.com (10.1.198.195) by dggema701-chm.china.huawei.com (10.3.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Tue, 6 Apr 2021 21:29:15 +0800 Received: from dggema753-chm.china.huawei.com ([10.9.48.84]) by dggema753-chm.china.huawei.com ([10.9.48.84]) with mapi id 15.01.2106.013; Tue, 6 Apr 2021 21:29:15 +0800 From: liweihang To: Leon Romanovsky CC: "dledford@redhat.com" , "jgg@nvidia.com" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: Re: [PATCH for-next] RDMA/core: Flush workqueue before destroy it Thread-Topic: [PATCH for-next] RDMA/core: Flush workqueue before destroy it Thread-Index: AQHXKsAgMoDr1XYHNUiyGdPyEI1T1Q== Date: Tue, 6 Apr 2021 13:29:15 +0000 Message-ID: <0efa41d4d17d42d3b43df895749376ff@huawei.com> References: <1617698091-47439-1-git-send-email-liweihang@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.100.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 2021/4/6 16:45, Leon Romanovsky wrote: > On Tue, Apr 06, 2021 at 04:34:51PM +0800, Weihang Li wrote: >> From: Yixian Liu >> >> It is safer to flush the workqueue before destroying it. > Sorry, safer for what? > > destroy_workqueue() flushes workqueue internally. There is no need to do > it twice. > > Thanks > My bad, thank you for reminding :) Weihang