From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Bob Pearson <rpearsonhpe@gmail.com>,
jgg@nvidia.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 3/6] RDMA/rxe: Register IP mcast address
Date: Mon, 6 Nov 2023 21:26:52 +0800 [thread overview]
Message-ID: <0f190158-d39f-45b0-be07-73977bfb40b7@linux.dev> (raw)
In-Reply-To: <a0b998f6-7c03-466e-b163-3317f7a5576c@gmail.com>
在 2023/11/6 4:19, Bob Pearson 写道:
>
>
> On 11/4/23 07:42, Zhu Yanjun wrote:
>
>>
>> Using reverse fir tree, a.k.a. reverse Christmas tree or reverse XMAS
>> tree, for
>>
>> variable declarations isn't strictly required, though it is still
>> preferred.
>>
>> Zhu Yanjun
>>
>>
> Yeah. I usually follow that style for new code (except if there are
> dependencies) but mostly add new variables at the end of the list
> together because it makes the patch simpler to read. At least it
> does for me. If you care, I am happy to fix this.
Yes. It is good to fix it.
And your commits add mcast address supports. And I think you
should have the test case in the rdma-core to verify these commits.
Can you share the test case in the rdma maillist? ^_^
Zhu Yanjun
>
> Bob
next prev parent reply other threads:[~2023-11-06 13:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 20:43 [PATCH for-next 0/6] RDMA/rxe: Make multicast actually work Bob Pearson
2023-11-03 20:43 ` [PATCH for-next 1/6] RDMA/rxe: Cleanup rxe_ah/av_chk_attr Bob Pearson
2023-11-03 20:43 ` [PATCH for-next 2/6] RDMA/rxe: Handle loopback of mcast packets Bob Pearson
2023-11-04 12:30 ` Zhu Yanjun
2023-11-03 20:43 ` [PATCH for-next 3/6] RDMA/rxe: Register IP mcast address Bob Pearson
2023-11-04 12:42 ` Zhu Yanjun
2023-11-05 20:19 ` Bob Pearson
2023-11-06 13:26 ` Zhu Yanjun [this message]
2023-11-06 17:31 ` Bob Pearson
2023-11-08 1:24 ` Zhu Yanjun
2023-11-03 20:43 ` [PATCH for-next 4/6] RDMA/rxe: Let rxe_lookup_mcg use rcu_read_lock Bob Pearson
2023-11-03 20:43 ` [PATCH for-next 5/6] RDMA/rxe: Split multicast lock Bob Pearson
2023-11-03 20:43 ` [PATCH for-next 6/6] RDMA/rxe: Cleanup mcg lifetime Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f190158-d39f-45b0-be07-73977bfb40b7@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox